Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n]: add support for XLIFF 2.0 serializer #11735

Closed
panuruj opened this issue Sep 19, 2016 · 5 comments · Fixed by #14185
Closed

[i18n]: add support for XLIFF 2.0 serializer #11735

panuruj opened this issue Sep 19, 2016 · 5 comments · Fixed by #14185
Labels
area: i18n feature Issue that requests a new feature

Comments

@panuruj
Copy link

panuruj commented Sep 19, 2016

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
The ng-xi18n and ngc are currently supporting XLIFF v.1.2.

Expected behavior
There should be an option to also generate/consume XLIFF v.2.0.

What is the motivation / use case for changing the behavior?
XLIFF v.2.0 became a standard in 2014, and the schema is very similar to v.1.2. Many of our localization vendors are accepting XLIFF 2.0, so it is desirable to be able to extract and consume XLIFF 2.0 directly. Today, we have to script the conversion from v.1.2 to/from v.2.0.
@vicb vicb added feature Issue that requests a new feature area: i18n labels Sep 19, 2016
@vicb
Copy link
Contributor

vicb commented Sep 19, 2016

Do you know what the diffs are in 2.0 vs 1.2 ?

@panuruj
Copy link
Author

panuruj commented Sep 19, 2016 •
edited by vicb
Loading

I have attached a manual conversion of v1.2 to v2.0.

Here are the differences:

* No <body>
* <trans-unit> becomes <unit>
* <segment> element under <unit>
* <note> must be a child of <notes> within <unit>
* Instead of <x>, the placeholders are represented as <pc> or <ph>
* There are a few other minor changes to the attribute names.

messages.v1.2.xlf.txt
messages.v2.xlf.txt

@vicb
Copy link
Contributor

vicb commented Sep 19, 2016

thanks for the details. We will consider this for a future release (PR welcome, however the xliff 1.2 impl probably need some love before it can be used as a starting point)

@panuruj panuruj mentioned this issue Nov 2, 2016
Closed
3 tasks
@panuruj panuruj mentioned this issue Jan 30, 2017
Merged
3 tasks
panuruj added a commit to panuruj/angular that referenced this issue Feb 13, 2017
@panuruj
feat(i18n): Implement XLIFF 2.0 serializer
5dcff8a 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 13, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
e197a5e 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 13, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
b9abf6f 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 13, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
bc28b78 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 24, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
04112b5 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 24, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
1080d9b 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Feb 24, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
c89f661 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Mar 6, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
245fd04 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Apr 7, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
325a638 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Apr 7, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
35395ee 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Apr 7, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
6c9918d 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Apr 7, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
3b937be 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
panuruj added a commit to panuruj/angular that referenced this issue Apr 8, 2017
@panuruj
feat(compiler): Implement i18n XLIFF 2.0 serializer
0f8bd51 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
tbosch pushed a commit that referenced this issue Apr 14, 2017
@tbosch
feat(compiler): Implement i18n XLIFF 2.0 serializer (#14185)
09c4cb2 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes #11735
@shbhar
Copy link

shbhar commented Apr 14, 2017

@tbosch, any idea when this is going to make it into a beta? I also need this if possible

mhevery pushed a commit that referenced this issue Apr 21, 2017
@mhevery
feat(compiler): Implement i18n XLIFF 2.0 serializer (#14185)
a7d8edd 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes #11735
mhevery pushed a commit that referenced this issue Apr 21, 2017
@mhevery
feat(compiler): Implement i18n XLIFF 2.0 serializer (#14185)
4c0c1e5 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes #11735
@martinroob martinroob mentioned this issue Apr 26, 2017
Closed
@ocombe ocombe mentioned this issue May 2, 2017
Closed
20 tasks
@martinroob martinroob mentioned this issue May 4, 2017
Closed
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
feat(compiler): Implement i18n XLIFF 2.0 serializer (angular#14185)
d2980d0 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@juleskremer
feat(compiler): Implement i18n XLIFF 2.0 serializer (angular#14185)
f871afc 
- Ensure that the result passes OASIS XLIFF 2.0 schema validation
- Use <ph/> for self-closing placeholder tags
- Use <pc></pc> for other placeholder tags
- Check for the correct XLIFF file version
- Add ICU support

fixes angular#11735
@EvanCarroll EvanCarroll mentioned this issue Sep 19, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: i18n feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
3 participants
@vicb @panuruj @shbhar