Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent jasmine focus tests #11800

Closed
vicb opened this issue Sep 21, 2016 · 1 comment
Closed

Prevent jasmine focus tests #11800

vicb opened this issue Sep 21, 2016 · 1 comment
Labels
area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature help wanted An issue that is suitable for a community contributor (based on its complexity/scope).

Comments

@vicb
Copy link
Contributor

vicb commented Sep 21, 2016

What about switching to a tslint rule ?

  • probably more robust than the current solution,
  • would work on gulp lint

ref: https://github.com/vrsource/vrsource-tslint-rules / "no-jasmine-focus"

/cc @pkozlowski-opensource
@vicb vicb added feature Issue that requests a new feature area: build & ci Related the build and CI infrastructure of the project help wanted An issue that is suitable for a community contributor (based on its complexity/scope). labels Sep 21, 2016
gary-b added a commit to gary-b/angular that referenced this issue Oct 26, 2016
@gary-b
build: tslint checks for prohibited jasmine calls
657b8be 
Previously a separate dependency was used to check that developers do
not commit jasmine focussed tests, eg fit, fdescribe. Add a new rule to
tslint to check for these function calls, with configuration options to
set the files to apply the rule to and support checking for excluded
tests in future.

Closes angular#11800
@gary-b gary-b mentioned this issue Oct 26, 2016
Closed
3 tasks
@alfaproject alfaproject mentioned this issue Oct 27, 2016
Closed
3 tasks
vsavkin pushed a commit to vsavkin/angular that referenced this issue Nov 3, 2016
@alfaproject @vsavkin
chore(lint): replace gulp check-task with tslint no-jasmine-focus rule
35f551d 
fixes angular#11800
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature help wanted An issue that is suitable for a community contributor (based on its complexity/scope).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lint): add some vrsource tslint rules
1 participant
@vicb