Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox issue with property decorators #12224

Closed
sentyaev opened this issue Oct 11, 2016 · 1 comment · Fixed by #12227
Closed

Firefox issue with property decorators #12224

sentyaev opened this issue Oct 11, 2016 · 1 comment · Fixed by #12227

Comments

@sentyaev
Copy link

sentyaev commented Oct 11, 2016

I'm submitting a ...

[ x ] bug report

Current behavior
When name of property is watch and this property marked with property decorator (Input or Output) in Firefox I see issue like unshift is not a function. I found that this line of code meta[name] = meta[name] || []; returns watch() function instead of property metadata.

Expected behavior
From my point of view watch is not a reserved name for variables or properties, so we should be able to create properties with name watch.

Minimal reproduction of the problem with instructions
This is only Firefox issue, in Chrome it works fine.
Plunker to reproduce: https://plnkr.co/edit/pL19LMYTJ27Th2zWUPLH

Please tell us about your environment: Windows 10, Firefox 49.0.1

  • Angular version: 2.0.2
  • Browser: Firefox 49.0.1
  • Language: TypeScript 2.0.2
vicb added a commit to vicb/angular that referenced this issue Oct 12, 2016
vicb added a commit to vicb/angular that referenced this issue Oct 12, 2016
IgorMinar pushed a commit that referenced this issue Oct 18, 2016
IgorMinar pushed a commit that referenced this issue Oct 18, 2016
btrigueiro pushed a commit to btrigueiro/angular that referenced this issue Oct 21, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants