Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Watch Mode for AoT compiler #12867

Closed
tbosch opened this issue Nov 14, 2016 · 7 comments
Closed

Tracking: Watch Mode for AoT compiler #12867

tbosch opened this issue Nov 14, 2016 · 7 comments
Assignees
@tbosch
Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Projects
Core

Comments

@tbosch
Copy link
Contributor

tbosch commented Nov 14, 2016

No description provided.

@tbosch tbosch self-assigned this Nov 14, 2016
tbosch added a commit to tbosch/angular that referenced this issue Nov 15, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
d2f2ed0 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
@vicb vicb added area: core Issues related to the framework runtime feature Issue that requests a new feature labels Nov 15, 2016
tbosch added a commit to tbosch/angular that referenced this issue Nov 15, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
30a85bc 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
tbosch added a commit to tbosch/angular that referenced this issue Nov 16, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
637624d 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
tbosch added a commit to tbosch/angular that referenced this issue Nov 16, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
53d2275 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
tbosch added a commit to tbosch/angular that referenced this issue Nov 17, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
567a9ea 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
tbosch added a commit to tbosch/angular that referenced this issue Nov 17, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
6682e72 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
tbosch added a commit to tbosch/angular that referenced this issue Nov 18, 2016
@tbosch
refactor(compiler): move static_reflector into @angular/compiler …
a56a8f6 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of angular#12867
chuckjaz pushed a commit that referenced this issue Nov 18, 2016
@tbosch @chuckjaz
refactor(compiler): move static_reflector into @angular/compiler …
912ca44 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of #12867
chuckjaz pushed a commit that referenced this issue Nov 22, 2016
@tbosch @chuckjaz
refactor(compiler): move static_reflector into @angular/compiler …
8f29528 
…and rename files

- `src/runtime_compiler.ts` -> `src/jit/compiler.ts`
- `src/compiler.ts` -> `src/jit/compiler_factory.ts`
- `src/offline_compiler` -> `src/aot/compiler.ts`

Part of #12867
@sonicoder86 sonicoder86 mentioned this issue Nov 26, 2016
Closed
@sonicoder86
Copy link

@tbosch what is the ETA of this feature?

@tbosch
Copy link
Contributor Author

tbosch commented Dec 28, 2016

@BlackSonic hopefully we will have this in late spring for 4.0...

@wenerme
Copy link

wenerme commented May 13, 2017

4.1.2 now, any progress ?

@geoff-mci geoff-mci mentioned this issue Jul 12, 2017
Closed
@ocombe ocombe mentioned this issue Aug 16, 2017
Closed
@Joge97
Copy link

Joge97 commented Sep 5, 2017

@tbosch any progress?

@tbosch
Copy link
Contributor Author

tbosch commented Oct 4, 2017

That's done now. We have a new internal api that we will make public eventually once it has proven to be stable enough. See https://github.com/angular/angular/blob/master/packages/compiler-cli/src/transformers/api.ts. This is modeled like the TypeScript API, and incremental compilations are done by passing an oldProgram when calling createProgram.

The command line ngc also has a -w option now that watches the file system and we see speedups for subsequent builds of up to 10x, as we have some logic in place to only compile components in node_modules 1x.

@tbosch tbosch closed this as completed Oct 4, 2017
@darekf77
Copy link

Hi @tbosch. Thanks for any help with this issue #23570.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbosch tbosch

Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Projects
No open projects
Core
Sprint Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vicb @sonicoder86 @tbosch @wenerme @darekf77 @Joge97