fix(dom_adapter): remove logError from logGroup #12925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzmitryShylovich
changed the title
DzmitryShylovich
force-pushed
the
gh/12923
branch
from
8615908
to
edc347a
Compare
DzmitryShylovich
changed the title
vicb
reviewed
Nov 17, 2016
| @@ -79,7 +79,7 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter { | |||
| // TODO(tbosch): move this into a separate environment class once we have it | |||
| logError(error: string): void { | |||
| if (window.console) { | |||
| (window.console.error || window.console.log)(error); | |||
There was a problem hiding this comment.
the behavior is not the same here (former is try error then log)
vicb
reviewed
Nov 17, 2016
| @@ -92,7 +92,6 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter { | |||
| logGroup(error: string): void { | |||
| if (window.console) { | |||
| window.console.group && window.console.group(error); | |||
| this.logError(error); | |||
There was a problem hiding this comment.
probably reasonable, have you check the call sites to see if we do not rely on this printing an error ?
There was a problem hiding this comment.
DzmitryShylovich
force-pushed
the
gh/12923
branch
from
edc347a
to
34eaa34
Compare
vicb
added
action: merge
vicb
pushed a commit
that referenced
this pull request
Dec 15, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12923