Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dom_adapter): remove logError from logGroup #12925

Merged
merged 1 commit into from Dec 9, 2016
Merged

fix(dom_adapter): remove logError from logGroup #12925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/@angular/platform-browser/src/browser/browser_adapter.ts
View file
Open in desktop
Expand Up @@ -79,7 +79,11 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
// TODO(tbosch): move this into a separate environment class once we have it
logError(error: string): void {
if (window.console) {
(window.console.error || window.console.log)(error);
if (console.error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the behavior is not the same here (former is try error then log)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

console.error(error);
} else {
console.log(error);
}
}
}

Expand All @@ -92,7 +96,6 @@ export class BrowserDomAdapter extends GenericBrowserDomAdapter {
logGroup(error: string): void {
if (window.console) {
window.console.group && window.console.group(error);
this.logError(error);
}
}

Expand Down