Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceUlr, skipLocationChange doesn't work in routerLink (@angular/router@3.3.0-beta.1) #13156

Closed
yoelp opened this issue Nov 30, 2016 · 2 comments

Comments

@yoelp
Copy link

yoelp commented Nov 30, 2016

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

PR #12850 has a fix for #12849 , but it actually doesn't work
when passing replaceUrl or skipLocationChange to routerLink it does not take affect

Expected behavior

It should behave as when passed to a router.navigate request

Minimal reproduction of the problem with instructions
See plunkr https://plnkr.co/edit/MEEad3YqXWzauoBxYgvr?p=preview (open in popup to see the url change, and history entry)

What is the motivation / use case for changing the behavior?

Please tell us about your environment: NA

  • Angular version: router 3.3.0-beta.1
  • Browser: [all]
  • Language: [all]

  • Node (for AoT issues): node --version =

@vicb
Copy link
Contributor

vicb commented Dec 1, 2016

true the skipLocationChange should be passed here: this.router.navigateByUrl(...);

vicb added a commit to vicb/angular that referenced this issue Dec 2, 2016
vicb added a commit to vicb/angular that referenced this issue Dec 2, 2016
vicb added a commit to vicb/angular that referenced this issue Dec 2, 2016
@alxhub alxhub closed this as completed in f562cbf Dec 5, 2016
maxime-allex pushed a commit to Linkurious/angular that referenced this issue Dec 6, 2016
maxime-allex pushed a commit to Linkurious/angular that referenced this issue Dec 6, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants