Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): record angular version in the dom #13164

Merged
merged 1 commit into from
Nov 30, 2016
Merged

feat(build): record angular version in the dom #13164

merged 1 commit into from
Nov 30, 2016

Conversation

vsavkin
Copy link
Contributor

@vsavkin vsavkin commented Nov 30, 2016

No description provided.

@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 30, 2016
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker pr_state: LGTM and removed action: merge The PR is ready for merge by the caretaker labels Nov 30, 2016
@mhevery
Copy link
Contributor

mhevery commented Nov 30, 2016

Please wrap in object, LGTM otherwise.

@vsavkin vsavkin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 30, 2016
@alxhub alxhub merged commit e628b66 into angular:master Nov 30, 2016
@IgorMinar
Copy link
Contributor

have we considered attaching the version info to the root element(s) instead of body?

I think it would be useful to clearly see what is/are the application root(s) and in the future if we allow multiple versions of Angular on the same page (like is being proposed for SharePoint), we'd naturally scope the versions to root elements and in that case we'd have various root elements tagged with their corresponding versions.

gkalpak
gkalpak reviewed Dec 1, 2016
View reviewed changes
modules/@angular/core/src/version.ts

get minor(): string { return this.full.split('.')[1]; }

get patch(): string { return this.full.split('.')[2]; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that patch will include pre-release identifiers? E.g. for new Version('2.0.0-rc.1'), I would expect patch to be '0', nit '0-rc.1'.

@born2net
Copy link

born2net commented Dec 1, 2016 •
edited
Loading

cool:

image

sweeet....

Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/Angular-kitchen-sink
Regards,

Sean

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

Assignees

@mhevery mhevery

Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsavkin @mhevery @IgorMinar @born2net @gkalpak @alxhub @googlebot