Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static members not validated for errors in strictMetadata mode #13481

Closed
hansl opened this issue Dec 14, 2016 · 2 comments · Fixed by #14772
Closed

Static members not validated for errors in strictMetadata mode #13481

hansl opened this issue Dec 14, 2016 · 2 comments · Fixed by #14772
Labels
effort1: hours freq1: low type: bug/fix

Comments

@hansl
Copy link
Contributor

hansl commented Dec 14, 2016

ngc check errors and report them for members and functions, but not static members.
@hansl
Copy link
Contributor Author

hansl commented Dec 14, 2016

Please note that this means we might be missing errors and could be releasing a version of Angular which is not AoT compatible.

@chuckjaz chuckjaz changed the title Static members not collected for errors in strictMetadata mode Static members not validated for errors in strictMetadata mode Feb 27, 2017
chuckjaz added a commit to chuckjaz/angular that referenced this issue Feb 27, 2017
@chuckjaz
fix(tsc-wrapped): validate metadata in static members of a class
10fa536 
Fixes angular#13481
@chuckjaz chuckjaz mentioned this issue Feb 27, 2017
Merged
IgorMinar pushed a commit that referenced this issue Mar 1, 2017
@chuckjaz @IgorMinar
fix(tsc-wrapped): validate metadata in static members of a class (#14772
a6996a9 
)

Fixes #13481
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this issue Mar 18, 2017
@chuckjaz @SamVerschueren
fix(tsc-wrapped): validate metadata in static members of a class (ang…
a3b4ea1 
…ular#14772)

Fixes angular#13481
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@chuckjaz
fix(tsc-wrapped): validate metadata in static members of a class (ang…
ecf9e1d 
…ular#14772)

Fixes angular#13481
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@chuckjaz @juleskremer
fix(tsc-wrapped): validate metadata in static members of a class (ang…
418cc37 
…ular#14772)

Fixes angular#13481
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort1: hours freq1: low type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tsc-wrapped): validate metadata in static members of a class chuckjaz/angular
2 participants
@chuckjaz @hansl