-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core API: implementing Renderer requires types from private exports #14001
Comments
|
DzmitryShylovich
added a commit
to DzmitryShylovich/angular
that referenced
this issue
Jan 18, 2017
DzmitryShylovich
added a commit
to DzmitryShylovich/angular
that referenced
this issue
Jan 19, 2017
DzmitryShylovich
added a commit
to DzmitryShylovich/angular
that referenced
this issue
Jan 23, 2017
alxhub
pushed a commit
that referenced
this issue
Jan 24, 2017
alxhub
pushed a commit
that referenced
this issue
Jan 25, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this issue
Aug 28, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
idlechara
pushed a commit
to idlechara/angular
that referenced
this issue
Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ... (check one with "x")
Current behavior
The
animate
abstract method from theRenderer
abstract class is defined using types only available though private exports, namely:AnimationStyles
,AnimationKeyframe
,AnimationPlayer
,NoOpAnimationPlayer
.Expected behavior
All the types to implement
animate
are public, or theanimate
is not required in theRenderer
.Minimal reproduction of the problem with instructions
RootRenderer
injectable service with a customRenderer
implemention.Renderer
without theanimate
method. After trying to add it, the issue occurs.What is the motivation / use case for changing the behavior?
The
Renderer
is a public API, although experimental. Implementing aRenderer
makes low-level DOM adjustments possible, those are sometimes essential to use together with third-party component libraries, such asPolymer
.As for now, a custom
Renderer
implementation is not achievable without importing the animation types mentioned above from private core exports.Please tell us about your environment:
The text was updated successfully, but these errors were encountered: