-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[http] RequestOptions is necessary for params
(introduced in 4.0.0-beta.0)
#14100
Comments
cexbrayat
added a commit
to cexbrayat/angular
that referenced
this issue
Jan 25, 2017
`params` has been introduced in 4.0.0-beta.0 Before: http.get(url, new RequestOptions({params: searchParams})) After: http.get(url, {params: searchParams}) Fixes angular#14100
3 tasks
mhevery
pushed a commit
that referenced
this issue
Feb 2, 2017
mhevery
pushed a commit
that referenced
this issue
Feb 3, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this issue
Feb 3, 2017
`params` has been introduced in 4.0.0-beta.0 Before: http.get(url, new RequestOptions({params: searchParams})) After: http.get(url, {params: searchParams}) Fixes angular#14100 PR Close angular#14101
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this issue
Aug 11, 2017
`params` has been introduced in 4.0.0-beta.0 Before: http.get(url, new RequestOptions({params: searchParams})) After: http.get(url, {params: searchParams}) Fixes angular#14100 PR Close angular#14101
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this issue
Aug 28, 2017
`params` has been introduced in 4.0.0-beta.0 Before: http.get(url, new RequestOptions({params: searchParams})) After: http.get(url, {params: searchParams}) Fixes angular#14100 PR Close angular#14101
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ... (check one with "x")
Current behavior
We can pass options to an HTTP call with
http.get(url, {search: searchParams})
, but the we can't with the newly introducedparams
that replaces the deprecatedsearch
(#13338 first released in 4.0.0-beta.0).For
params
, we have to wrap it in aRequestOptions
object:http.get(url, new RequestOptions({params: searchParams}))
.Fixed in #14101
Expected behavior
We should be able to pass the options directly without wrapping
http.get(url, {params: searchParams})
as we do for the other options.Angular version: 4.0.0-beta.4
Browser: all
Language: all
The text was updated successfully, but these errors were encountered: