Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language service crashes if the asked for completions and it cannot locate Angular #14122

Closed
chuckjaz opened this issue Jan 26, 2017 · 1 comment
Closed

Language service crashes if the asked for completions and it cannot locate Angular #14122

chuckjaz opened this issue Jan 26, 2017 · 1 comment

Comments

@chuckjaz
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting

Current behavior

Opening a TS project without angular will crash the language service.

Expected behavior

It should go dormant.
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jan 26, 2017
@chuckjaz
fix(language-service): do not crash when Angular cannot be located
bb8b580 
Fixes angular#14122
@chuckjaz chuckjaz mentioned this issue Jan 26, 2017
Closed
chuckjaz added a commit to chuckjaz/angular that referenced this issue Jan 31, 2017
@chuckjaz
fix(language-service): do not crash when Angular cannot be located
aac17f0 
Fixes angular#14122
mhevery pushed a commit that referenced this issue Feb 2, 2017
@chuckjaz @mhevery
fix(language-service): do not crash when Angular cannot be located (#…
4de425a 
…14123)

Fixes #14122

PR Close #14123
mhevery pushed a commit that referenced this issue Feb 3, 2017
@chuckjaz @mhevery
fix(language-service): do not crash when Angular cannot be located (#…
5909f2f 
…14123)

Fixes #14122

PR Close #14123
mhevery pushed a commit to mhevery/angular that referenced this issue Feb 3, 2017
@chuckjaz @mhevery
fix(language-service): do not crash when Angular cannot be located (a…
33a193b 
…ngular#14123)

Fixes angular#14122

PR Close angular#14123
mhevery pushed a commit to mhevery/angular that referenced this issue Feb 3, 2017
@chuckjaz @mhevery
fix(language-service): do not crash when Angular cannot be located (a…
a5b4af0 
…ngular#14123)

Fixes angular#14122

PR Close angular#14123
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@chuckjaz
fix(language-service): do not crash when Angular cannot be located (a…
5ffdb47 
…ngular#14123)

Fixes angular#14122

PR Close angular#14123
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@chuckjaz @juleskremer
fix(language-service): do not crash when Angular cannot be located (a…
5fa082d 
…ngular#14123)

Fixes angular#14122

PR Close angular#14123
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(language-service): do not crash when Angular cannot be located chuckjaz/angular
1 participant
@chuckjaz