Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate source maps for compiled templates #14125

Closed
tbosch opened this issue Jan 26, 2017 · 4 comments
Closed

Generate source maps for compiled templates #14125

tbosch opened this issue Jan 26, 2017 · 4 comments

Comments

@tbosch
Copy link
Contributor

tbosch commented Jan 26, 2017

The upcoming view engine (#14013) will rely on source maps for reporting the source location of errors.

For this we need a general support for source maps in our OutputAst and emitters (TypeScriptEmitter, jitStatements).
@tbosch tbosch mentioned this issue Jan 26, 2017
Closed
2 tasks
@tbosch
Copy link
Contributor Author

tbosch commented Jan 26, 2017

Main idea:
Add TemplateAst to Expression / Statement in output_ast.

@tbosch
Copy link
Contributor Author

tbosch commented Jan 26, 2017

See here for the TypeScript implementation of their source map emitter

@tbosch
Copy link
Contributor Author

tbosch commented Jan 26, 2017 •
edited by vicb
Loading

Write unit tests via source-map which we already have as a devDependency.

@vicb vicb mentioned this issue Feb 2, 2017
Closed
vicb added a commit to vicb/angular that referenced this issue Feb 2, 2017
@vicb
feat(compiler): add support for source map generation
3853a1b 
fixes angular#14125
vicb added a commit to vicb/angular that referenced this issue Feb 3, 2017
@vicb
feat(compiler): add support for source map generation
214fb1d 
fixes angular#14125
vicb added a commit to vicb/angular that referenced this issue Feb 3, 2017
@vicb
feat(compiler): add support for source map generation
6137e53 
fixes angular#14125
vicb added a commit to vicb/angular that referenced this issue Feb 3, 2017
@vicb
feat(compiler): add support for source map generation
ca2193a 
fixes angular#14125
vicb added a commit to vicb/angular that referenced this issue Feb 7, 2017
@vicb
feat(compiler): add support for source map generation
51dd975 
fixes angular#14125
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@vicb
feat(compiler): add support for source map generation (angular#14258)
69b2221 
fixes angular#14125

PR Close angular#14258
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@vicb @juleskremer
feat(compiler): add support for source map generation (angular#14258)
c3ad328 
fixes angular#14125

PR Close angular#14258
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compiler): add support for source map generation vicb/angular
2 participants
@vicb @tbosch