Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform-browser package incorrectly contains transpiled files misrepresented as ES6 #14857

Closed
mattmutt opened this issue Mar 2, 2017 · 4 comments

Comments

@mattmutt
Copy link

mattmutt commented Mar 2, 2017

I'm submitting a ... (check one with "x")

[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior
When checking out an Angular 4.0.0-rc.1 new project with all Angular assets pulled in with that exact version, the platform-browser contains a folder that eventually contain animation and testing.

that folder's relative path would be
@angular\platform-browser\@angular\platform-browser\animations

There are ES5 builds of for animations and testing. The problem is that the .es5.js files are incorrect. How can ES5 use the class keyword?

Expected behavior
The files must be ES5 compliant. That means transpile to functions.

Minimal reproduction of the problem with instructions

npm i @angular/animations@4.0.0-rc.1 zone.js rxjs @angular/core@4.0.0-rc.1 @angular/platform-browser@4.0.0-rc.1 @angular/common@4.0.0-rc.1

then change directory into
node_modules\@angular\platform-browser\@angular\platform-browser

Examine the alleged ES5 files animations.es5.js and testing.es5.js. Judge if the syntax complies with the older JS version.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Angular version: [4.0.0-rc.1]

latest version of 4

  • Browser: [IE11 ]

Mainly affects old school IE

  • Language: [ES5]

  • Node (for AoT issues): node --version =

@ericmartinezr
Copy link
Contributor

#14730

@mattmutt
Copy link
Author

mattmutt commented Mar 2, 2017

thanks will monitor that related defect

@DzmitryShylovich
Copy link
Contributor

@mattmutt fixed by #14820

@mattmutt mattmutt closed this as completed Mar 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants