build: fix secondary entry point es5 output and core Rx references #14820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckjaz
approved these changes
Mar 1, 2017
Secondary entry points (testing, static, etc) are rolled up into a single ESM/ES2015 file, then downleveled to ESM/ES2015. This downleveling was not working and was producing ESM/ES2015. Also, the @angular/core package's .babelrc file was missing reference to Rx Observable which broke the UMD bundle. Fixes angular#14730
| "rxjs/Observer": "Rx", | ||
| "rxjs/Subscription": "Rx", | ||
|
|
||
| "rxjs/symbol/observable": "Rx.Symbol.observable", |
There was a problem hiding this comment.
I'm just not sure this is correct. I created an issue on rxjs repo ReactiveX/rxjs#2415 but they haven't answered anything >_<
There was a problem hiding this comment.
Yes, looks like you're right. Leaving in atm since this is going back to what previous rollup.config.js was. But it looks like it will be broken until the issue you filed gets fixed.
mhevery
approved these changes
Mar 1, 2017
SamVerschueren
pushed a commit
to SamVerschueren/angular
that referenced
this pull request
Mar 18, 2017
…ngular#14820) Secondary entry points (testing, static, etc) are rolled up into a single ESM/ES2015 file, then downleveled to ESM/ES2015. This downleveling was not working and was producing ESM/ES2015. Also, the @angular/core package's .babelrc file was missing reference to Rx Observable which broke the UMD bundle. Fixes angular#14730
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ngular#14820) Secondary entry points (testing, static, etc) are rolled up into a single ESM/ES2015 file, then downleveled to ESM/ES2015. This downleveling was not working and was producing ESM/ES2015. Also, the @angular/core package's .babelrc file was missing reference to Rx Observable which broke the UMD bundle. Fixes angular#14730
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ngular#14820) Secondary entry points (testing, static, etc) are rolled up into a single ESM/ES2015 file, then downleveled to ESM/ES2015. This downleveling was not working and was producing ESM/ES2015. Also, the @angular/core package's .babelrc file was missing reference to Rx Observable which broke the UMD bundle. Fixes angular#14730
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secondary entry points (testing, static, etc) are rolled up into a
single ESM/ES2015 file, then downleveled to ESM/ES2015. This downleveling
was not working and was producing ESM/ES2015. Also, the @angular/core
package's .babelrc file was missing reference to Rx Observable which
broke the UMD bundle.
Fixes #14730