Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Symbol support from DI or not #15183

Closed
IgorMinar opened this issue Mar 15, 2017 · 1 comment
Closed

Revert Symbol support from DI or not #15183

IgorMinar opened this issue Mar 15, 2017 · 1 comment
Assignees
@mhevery
Labels
area: core Issues related to the framework runtime
Milestone
4.0.0-blockers

Comments

@IgorMinar
Copy link
Contributor

@mhevery has details
@IgorMinar IgorMinar added this to the 4.0.0-blockers milestone Mar 15, 2017
@IgorMinar IgorMinar added the area: core Issues related to the framework runtime label Mar 15, 2017
mhevery added a commit to mhevery/angular that referenced this issue Mar 20, 2017
@mhevery
Revert "fix(compiler): shouldn't throw when Symbol is used as DI token (
f362726 
angular#13701)"

This reverts commit 8b5c6b2.

This feature is not compatible with the `Injector.get` which now only 
takes `Type` or `InjectableToken`. `Symbol` is not a valid type.

Closes angular#15183
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@mhevery
Revert "fix(compiler): shouldn't throw when Symbol is used as DI token (
f7c2d10 
angular#13701)" (angular#15319)

This reverts commit 8b5c6b2.

This feature is not compatible with the `Injector.get` which now only 
takes `Type` or `InjectableToken`. `Symbol` is not a valid type.

Closes angular#15183

PR Close angular#15319
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@mhevery @juleskremer
Revert "fix(compiler): shouldn't throw when Symbol is used as DI token (
0906027 
angular#13701)" (angular#15319)

This reverts commit 8b5c6b2.

This feature is not compatible with the `Injector.get` which now only 
takes `Type` or `InjectableToken`. `Symbol` is not a valid type.

Closes angular#15183

PR Close angular#15319
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhevery mhevery

Labels
area: core Issues related to the framework runtime
Projects
None yet
Milestone
4.0.0-blockers
Development

No branches or pull requests
2 participants
@mhevery @IgorMinar