Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngc's flatModuleOutFile does not emit metadata on windows #15192

Closed
filipesilva opened this issue Mar 15, 2017 · 2 comments
Closed

ngc's flatModuleOutFile does not emit metadata on windows #15192

filipesilva opened this issue Mar 15, 2017 · 2 comments
Assignees
Labels
area: core Issues related to the framework runtime type: bug/fix

Comments

@filipesilva
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Compiling using ngc and with flatModuleOutFile does not produce a *.metadata.json file on Windows.

Expected behavior

*.metadata.json file should be produced on all platforms.

Minimal reproduction of the problem with instructions

git clone https://github.com/filipesilva/ngc-flatmodule-windows
cd ngc-flatmodule-windows
npm run build

On a OSX machine, there will be a out-tsc/index.metadata.json. On Windows, this file will not be present.

What is the motivation / use case for changing the behavior?

ngc should work on Windows.

Please tell us about your environment:

Windows 10, VS Code, npm@4.0.5, node@7.4.0, typescript@2.2.1

  • Angular version: 4.0.0-rc.3
  • Browser: [ N/A ]
  • Language: [ TypeScript 2.2 ]

  • Node (for AoT issues): node --version = 7.4.0

@chuckjaz chuckjaz added area: core Issues related to the framework runtime type: bug/fix labels Mar 15, 2017
@chuckjaz chuckjaz added this to the 4.0.0-blocker-candidates milestone Mar 15, 2017
@chuckjaz chuckjaz modified the milestones: 4.0.0-blockers, 4.0.0-blocker-candidates Mar 16, 2017
chuckjaz added a commit to chuckjaz/angular that referenced this issue Mar 16, 2017
File name needed to be normalized before comparison when using
synthetic file names.

Fixes angular#15192
@chuckjaz
Copy link
Contributor

I reproduced the error and have a fix PR out to fix the Windows issue.

I also sent a PR for changes I would recommend to your library setup. The attached repository doesn't quite work as you are obscuring the index.ts in the source.

SamVerschueren pushed a commit to SamVerschueren/angular that referenced this issue Mar 18, 2017
…ar#15215)

File name needed to be normalized before comparison when using
synthetic file names.

Fixes angular#15192

PR Close angular#15215
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
…ar#15215)

File name needed to be normalized before comparison when using
synthetic file names.

Fixes angular#15192

PR Close angular#15215
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
…ar#15215)

File name needed to be normalized before comparison when using
synthetic file names.

Fixes angular#15192

PR Close angular#15215
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants