Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): add an empty content for source file of non mapped code. #15246

Closed
wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Mar 17, 2017

Before this when using ngc, tools tried to load ng://…<component>.ts
if …<component>.ts was the source file of a template.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Before this when using ngc, tools tried to load `ng://…<component>.ts`
if `…<component>.ts` was the source file of a template.
@tbosch tbosch requested a review from vicb March 17, 2017 17:32
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Mar 17, 2017
@mhevery mhevery closed this in 8415910 Mar 17, 2017
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this pull request Mar 18, 2017
…e. (angular#15246)

Before this when using ngc, tools tried to load `ng://…<component>.ts`
if `…<component>.ts` was the source file of a template.

PR Close angular#15246
@tbosch tbosch deleted the fix_sourcemaps branch April 28, 2017 23:41
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…e. (angular#15246)

Before this when using ngc, tools tried to load `ng://…<component>.ts`
if `…<component>.ts` was the source file of a template.

PR Close angular#15246
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…e. (angular#15246)

Before this when using ngc, tools tried to load `ng://…<component>.ts`
if `…<component>.ts` was the source file of a template.

PR Close angular#15246
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants