Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n's ph value doesn't allow single quotes, only double quotes #15318

Closed
robertorfischer opened this issue Mar 20, 2017 · 1 comment
Closed

Comments

@robertorfischer
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

<span i18n="description">begin message {{param // i18n(ph = "name")}} end</span>

In i18n's ph value, only double quotes are allowed. Single quotes are not and the placeholder is ignored.

Expected behavior

Expected to be able to use single quotes too.

Minimal reproduction of the problem with instructions

  • Angular version: 4.0.0-rc.5
@ocombe ocombe self-assigned this Mar 21, 2017
ocombe added a commit to ocombe/angular that referenced this issue Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes

Fixes angular#15318
ocombe added a commit to ocombe/angular that referenced this issue Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes

Fixes angular#15318
ocombe added a commit to ocombe/angular that referenced this issue Mar 24, 2017
The regex that extract named interpolations for i18n placeholders only allowed double quotes, this PR adds the ability to use single quotes

Fixes angular#15318
@vicb vicb closed this as completed in 53b89ec Mar 24, 2017
@ocombe ocombe mentioned this issue May 2, 2017
20 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants