Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): correctly handle when toString is exported #15430

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

chuckjaz
Copy link
Contributor

Fixes #15420

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix

What is the current behavior? (You can also link to an open issue here)

#15420

A fix for flat module indexes (90d2518) broke the non-flat module case where an export matched the name of a method on the Object prototype.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@chuckjaz chuckjaz added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 23, 2017
@chuckjaz chuckjaz added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 23, 2017
@vicb vicb merged commit 0dda01e into angular:master Mar 23, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0.0-rc.6 AOT regression: exporting function named toString breaks AoT
4 participants