Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal from tsd.json doesn't clean up typings folder #1636

Closed
alexeagle opened this issue May 1, 2015 · 9 comments
Closed

Removal from tsd.json doesn't clean up typings folder #1636

alexeagle opened this issue May 1, 2015 · 9 comments
Assignees

Comments

@alexeagle
Copy link
Contributor

reported by @juliemr

@alexeagle alexeagle self-assigned this May 1, 2015
@alexeagle
Copy link
Contributor Author

/sub @vsavkin

@alexeagle
Copy link
Contributor Author

I think it's an issue in tsd, actually. Filed DefinitelyTyped/tsd#151

@alexeagle
Copy link
Contributor Author

Not sure yet how frequent this problem will be, so I'm going to prioritize other things. If it bites us again, we can do something like force-delete the typings every time. Or, maybe it will be fixed upstream before then.

@alexeagle
Copy link
Contributor Author

FYI for the team:
fix is rm -rf modules/angular2/typings and then tsd reinstall --config=modules/angular2/tsd.json

@mhevery mhevery added this to the M10: Sugar milestone May 5, 2015
@mhevery mhevery removed this from the Backlog milestone May 29, 2015
@alexeagle alexeagle self-assigned this Aug 19, 2015
@alexeagle
Copy link
Contributor Author

We can fix this now that From DefinitelyTyped/tsd#184 (comment) is available

@mhevery
Copy link
Contributor

mhevery commented Aug 24, 2015

@alexeagle is this still an issue?

@alexeagle
Copy link
Contributor Author

Yes, we are waiting on a tsd release so we can use the new flag. Let's keep this issue open to remind us to do that.
AT present, tsd is @0.6.3 which doesn't include this.

@alexeagle
Copy link
Contributor Author

tsd 0.6.4 was released so I'll try to fix this now.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants