Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(aio): confirm ga tracks user’s # fragment clicks within a page #16441

Merged
merged 1 commit into from Apr 30, 2017

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Apr 30, 2017

This was the behavior and we think we still want to do it.
Added comment and test to confirm that is our present intention.

See @IgorMinar issue #16293 and issue #16442

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@wardbell wardbell added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2017
@wardbell wardbell self-assigned this Apr 30, 2017
@wardbell wardbell added this to REVIEW in docs-infra Apr 30, 2017
@mary-poppins
Copy link

The angular.io preview for 4ac3401 is available here.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 30, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Apr 30, 2017
@wardbell wardbell force-pushed the aio-ga-tracks-hash-only-changes branch 2 times, most recently from a820cb3 to c48427c Compare April 30, 2017 10:13
This was the behavior and we think we still want to do it.
Added comment and test to confirm that is our present intention.
@wardbell wardbell force-pushed the aio-ga-tracks-hash-only-changes branch from c48427c to 3b13300 Compare April 30, 2017 10:15
@mary-poppins
Copy link

The angular.io preview for a820cb3 is available here.

@mary-poppins
Copy link

The angular.io preview for c48427c is available here.

@mary-poppins
Copy link

The angular.io preview for 3b13300 is available here.

@mhevery mhevery merged commit de8de84 into angular:master Apr 30, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Apr 30, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…ngular#16441)

This was the behavior and we think we still want to do it.
Added comment and test to confirm that is our present intention.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…ngular#16441)

This was the behavior and we think we still want to do it.
Added comment and test to confirm that is our present intention.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants