Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: decide what to do about whether to display "pure" tag on Pipes #16641

Closed
petebacondarwin opened this issue May 8, 2017 · 2 comments · Fixed by #16655
Closed

aio: decide what to do about whether to display "pure" tag on Pipes #16641

petebacondarwin opened this issue May 8, 2017 · 2 comments · Fixed by #16655
Assignees
@IgorMinar

Comments

@petebacondarwin
Copy link
Member

The Pipes API docs contain information about whether the Pipe is pure or not.
We need to decide if this should be displayed in the doc, and if so how.
@petebacondarwin petebacondarwin added this to TODO in docs-infra May 9, 2017
@petebacondarwin petebacondarwin moved this from TODO to TODO Blockers in docs-infra May 9, 2017
@IgorMinar
Copy link
Contributor

Let's not display it for now. Pipe purity is an implementation detail that shouldn't be important to the reader.

if we realize that somehow that information should be surfaced, we'll deal with it then.

petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 9, 2017
@petebacondarwin
build(aio): remove "pure" property from pipe template
f5624bf 
This information is not relevant to users, right now.

Closes angular#16641
@petebacondarwin petebacondarwin mentioned this issue May 9, 2017
Merged
@wardbell wardbell removed this from TODO Blockers in docs-infra May 9, 2017
jasonaden pushed a commit that referenced this issue May 9, 2017
@petebacondarwin @jasonaden
build(aio): remove "pure" property from pipe template (#16655)
7b4a8d5 
This information is not relevant to users, right now.

Closes #16641
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
build(aio): remove "pure" property from pipe template (angular#16655)
9736d93 
This information is not relevant to users, right now.

Closes angular#16641
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
build(aio): remove "pure" property from pipe template (angular#16655)
995d0eb 
This information is not relevant to users, right now.

Closes angular#16641
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@IgorMinar IgorMinar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(aio): remove "pure" property from pipe template petebacondarwin/angular
2 participants
@petebacondarwin @IgorMinar