Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up the preview deployment #16705

Closed
IgorMinar opened this issue May 10, 2017 · 1 comment · Fixed by #16734
Closed

Speed up the preview deployment #16705

IgorMinar opened this issue May 10, 2017 · 1 comment · Fixed by #16734
Assignees
@gkalpak
Labels
area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature

Comments

@IgorMinar
Copy link
Contributor

Currently the deployment to the preview server happens as one of the last steps in our CI. This means that if we want to preview a change we need to wait for all the other tests to finish, and what's worse we also need all the tests to pass.

It would be better if we deployed the preview as soon as we have a build before (or in parallel with) running all the tests. This way, we get the previews faster and we get them even if some tests fail (which contrary to deployment to staging a a good thing).
@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature comp: aio labels May 10, 2017
@gkalpak gkalpak added this to REVIEW in docs-infra May 10, 2017
@gkalpak gkalpak moved this from REVIEW to TODO in docs-infra May 10, 2017
@IgorMinar IgorMinar moved this from TODO to TODO Blockers in docs-infra May 11, 2017
gkalpak added a commit to gkalpak/angular that referenced this issue May 11, 2017
@gkalpak
ci(aio): deploy previews early (right after build)
42fe237 
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
@gkalpak gkalpak mentioned this issue May 11, 2017
Merged
gkalpak added a commit to gkalpak/angular that referenced this issue May 11, 2017
@gkalpak
ci(aio): deploy previews early (right after build)
fec6c42 
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
IgorMinar pushed a commit that referenced this issue May 11, 2017
@gkalpak @IgorMinar
ci(aio): deploy previews early (right after build) (#16734)
fdfeaaf 
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes #16705
@gkalpak gkalpak removed this from TODO Blockers in docs-infra May 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@gkalpak
ci(aio): deploy previews early (right after build) (angular#16734)
b169691 
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@gkalpak @juleskremer
ci(aio): deploy previews early (right after build) (angular#16734)
2b76a9c 
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gkalpak gkalpak

Labels
area: build & ci Related the build and CI infrastructure of the project feature Issue that requests a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(aio): deploy previews early (right after build) gkalpak/angular
2 participants
@IgorMinar @gkalpak