Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(aio): deploy previews early (right after build) #16734

Merged
merged 1 commit into from May 11, 2017

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented May 11, 2017

Previously, PR previews were deployed after successfully running all tests. While this makes sense for staging/production deployments, previews should be available as soon as possible (and regardless of the outcome of tests).

Fixes #16705.

@gkalpak
Copy link
Member Author

gkalpak commented May 11, 2017

Builds on top of #16733.

@gkalpak gkalpak requested a review from IgorMinar May 11, 2017 20:39
@gkalpak gkalpak added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 11, 2017
@gkalpak gkalpak added this to REVIEW in docs-infra May 11, 2017
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
@gkalpak gkalpak force-pushed the ci-aio-deploy-preview-sooner branch from 42fe237 to fec6c42 Compare May 11, 2017 22:09
@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 11, 2017
@IgorMinar IgorMinar merged commit fdfeaaf into angular:master May 11, 2017
@gkalpak gkalpak deleted the ci-aio-deploy-preview-sooner branch May 11, 2017 22:41
@gkalpak gkalpak removed this from REVIEW in docs-infra May 12, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
Previously, PR previews were deployed after successfully running all tests.
While this makes sense for staging/production deployments, previews should be
available as soon as possible (and regardless of the outcome of tests).

Fixes angular#16705
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up the preview deployment
3 participants