Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix public-api:update gulp task #16859

Merged
merged 1 commit into from May 22, 2017
Merged

build: fix public-api:update gulp task #16859

merged 1 commit into from May 22, 2017

Conversation

vicb
Copy link
Contributor

@vicb vicb commented May 18, 2017

Reverting to the slower but correct task for now.

@vicb
build: fix public-api:update gulp task
1392485 
PR angular#16834 makes the task faster but it doesn't work any more!
Reverting to the slower but correct task for now.
@vicb vicb changed the title build: fix public-api:update build: fix public-api:update gulp task May 18, 2017
@vicb vicb requested a review from IgorMinar May 18, 2017 00:07
@vicb vicb added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer labels May 18, 2017
IgorMinar
IgorMinar approved these changes May 18, 2017
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it's weird that we need this. Is it because of the flattened index files or why?

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 18, 2017
@juliemr juliemr mentioned this pull request May 18, 2017
Merged
@chuckjaz chuckjaz merged commit 98849de into angular:master May 22, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@vicb
build: fix public-api:update gulp task (angular#16859)
2bdc5d5 
PR angular#16834 makes the task faster but it doesn't work any more!
Reverting to the slower but correct task for now.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@vicb @juleskremer
build: fix public-api:update gulp task (angular#16859)
42f28aa 
PR angular#16834 makes the task faster but it doesn't work any more!
Reverting to the slower but correct task for now.
@vicb vicb deleted the 0517-pulicapi branch March 6, 2018 22:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicb @IgorMinar @chuckjaz @googlebot