Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or move "Docs" sidenav item from the list in the mobile view #16940

Closed
IgorMinar opened this issue May 22, 2017 · 2 comments · Fixed by #16967
Closed

Remove or move "Docs" sidenav item from the list in the mobile view #16940

IgorMinar opened this issue May 22, 2017 · 2 comments · Fixed by #16967
Assignees
@petebacondarwin
Labels
type: bug/fix

Comments

@IgorMinar
Copy link
Contributor

screen shot 2017-05-22 at 2 56 01 pm

The "Docs" item is already expanded under all the marketing menu items, so it's not necessary to list it there. Can we remove it? Or should we move it to be the last in the list of marketing pages and add a colon or something to suggest that the items under are the docs menu subitems?
@gkalpak gkalpak added this to TODO Blockers in docs-infra May 22, 2017
@petebacondarwin
Copy link
Member

OK, we should definitely not do this through hard coding rules into the viewer.
One option is to have two different TopBar navigation views: one for wide screen and one for narrow screen. (At the moment we use the same view for both screen widths).

I think it is worth keeping the "Docs" menu item in the narrow view, as it does actually point to a real page. So let's go with moving it to the bottom.

@petebacondarwin petebacondarwin self-assigned this May 23, 2017
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 23, 2017
@petebacondarwin
fix(aio): use a special version of the TopBar if the screen is narrow
d623fdc 
If there is a `TopBarNarrow` nav view then use this when the screen is narrow.
Otherwise just use the normal `TopBar`.

This commit also creates such a narrow topbar view where the "Docs" item is
in a different position

Closes angular#16940
@petebacondarwin petebacondarwin moved this from TODO Blockers to REVIEW in docs-infra May 23, 2017
@petebacondarwin petebacondarwin mentioned this issue May 23, 2017
Merged
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue May 24, 2017
@petebacondarwin
fix(aio): use a special version of the TopBar if the screen is narrow
d4e658e 
If there is a `TopBarNarrow` nav view then use this when the screen is narrow.
Otherwise just use the normal `TopBar`.

This commit also creates such a narrow topbar view where the "Docs" item is
in a different position

Closes angular#16940
@petebacondarwin petebacondarwin removed this from REVIEW in docs-infra May 24, 2017
petebacondarwin added a commit that referenced this issue May 24, 2017
@petebacondarwin
fix(aio): use a special version of the TopBar if the screen is narrow
19a509a 
If there is a `TopBarNarrow` nav view then use this when the screen is narrow.
Otherwise just use the normal `TopBar`.

This commit also creates such a narrow topbar view where the "Docs" item is
in a different position

Closes #16940
asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@petebacondarwin
fix(aio): use a special version of the TopBar if the screen is narrow
8d9451d 
If there is a `TopBarNarrow` nav view then use this when the screen is narrow.
Otherwise just use the normal `TopBar`.

This commit also creates such a narrow topbar view where the "Docs" item is
in a different position

Closes angular#16940
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@petebacondarwin @juleskremer
fix(aio): use a special version of the TopBar if the screen is narrow
44e871b 
If there is a `TopBarNarrow` nav view then use this when the screen is narrow.
Otherwise just use the normal `TopBar`.

This commit also creates such a narrow topbar view where the "Docs" item is
in a different position

Closes angular#16940
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petebacondarwin petebacondarwin

Labels
type: bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(aio): use a special version of the TopBar if the screen is narrow petebacondarwin/angular
2 participants
@petebacondarwin @IgorMinar