Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): less verbose boilerplate generator #16970

Merged
merged 1 commit into from May 25, 2017
Merged

build(aio): less verbose boilerplate generator #16970

merged 1 commit into from May 25, 2017

Conversation

Foxandxss
Copy link
Member

There is a log that says "Copying example files". I opted to leave it.

@mary-poppins
Copy link

The angular.io preview for dc8bad9 is available here.

gkalpak
gkalpak approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@gkalpak
Copy link
Member

gkalpak commented May 23, 2017

Now we just have to get rid of these warnings 😃:

** WARNING: no "/home/travis/build/angular/angular/aio/content/examples/testing/src/systemjs.config.extras.web.js" replacement for "/home/travis/build/angular/angular/aio/content/examples/testing/src/systemjs.config.extras.js".

@Foxandxss
Copy link
Member Author

Tried, Pete asked me to leave it.

@gkalpak
Copy link
Member

gkalpak commented May 23, 2017

Pete asked you to not fix the warning? Why are we getting those warnings?

@Foxandxss
Copy link
Member Author

#16687

@petebacondarwin
Copy link
Member

Warnings are important no? If there is a warning it must mean something that we are supposed to pay attention to.

@gkalpak
Copy link
Member

gkalpak commented May 24, 2017

True in general. Not sure if it is true in this case.

@petebacondarwin
Copy link
Member

If they are not really warnings that need to be actioned then they should go too

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra May 24, 2017
@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label May 25, 2017
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra May 25, 2017
@chuckjaz chuckjaz merged commit 4c5e28e into angular:master May 25, 2017
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra May 26, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@Foxandxss
build(aio): less verbose boilerplate generator (angular#16970)
33b9bbf
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@Foxandxss @juleskremer
build(aio): less verbose boilerplate generator (angular#16970)
d5ba13e
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Foxandxss @mary-poppins @gkalpak @petebacondarwin @chuckjaz @googlebot