build(aio): make less verbose tools #16687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aio/tools/plunker-builder/builder.js
Outdated
| @@ -232,10 +232,10 @@ class PlunkerBuilder { | |||
| // console.log('** Substituted "' + webExtras + '" for "' + extras + '".'); | |||
| return fs.readFileSync(webExtras, 'utf-8'); | |||
| } else if (this._existsSync(extras)){ | |||
| console.log('** WARNING: no "' + webExtras + '" replacement for "' + extras + '".'); | |||
| // console.log('** WARNING: no "' + webExtras + '" replacement for "' + extras + '".'); | |||
There was a problem hiding this comment.
let's keep the warnings
There was a problem hiding this comment.
@petebacondarwin, why?
@Foxandxss, what are these warnings for? Are missing something we need to fix or is it normal for some of them to be missing?
There was a problem hiding this comment.
Exactly. If they are not actionable then they are just informative and can go.
petebacondarwin
added
the
area: build & ci
Foxandxss
force-pushed
the
aio-less-verbose-tools
branch
from
a19cc2e
to
cc5dec2
Compare
|
Done. |
petebacondarwin
approved these changes
May 10, 2017
petebacondarwin
added
the
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@petebacondarwin asked for the tools to be less verbose somewhere (is there an issue for that?)
I left some as a comment because I plan on revisit them.