refactor(common): Cleanup HttpClient's imports #18120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version includes a fix for potential cache corruption and invalid redirect behavior in rare cases.
…rowsers `innerText` is not supported in Firefox prior to v45. In most cases (at least the ones we are interested in), `innerText` and `textContent` work equally well, but `textContent` is more performant (as it doesn't require a reflow). From [MDN][1] on the differences of `innerText` vs `textContent`: > - [...] > - `innerText` is aware of style and will not return the text of hidden > elements, whereas `textContent` will. > - As `innerText` is aware of CSS styling, it will trigger a reflow, whereas > `textContent` will not. > - [...] [1]: https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent#Differences_from_innerText Fixes angular#17585
…ion patch releases
…during the build Fixes angular#17403
This version fixes the DISCONNECTED errors (described in angular#17543) and removes the need to the workaround (8af203c). The relevant jasmine commit is jasmine/jasmine@c60d66994.
…tives This reverts commit 232bd93.
With 4.2, we introduced the min and max validator directives. This was actually a breaking change because their selectors could include custom value accessors using the min/max properties for their own purposes. For now, we are rolling back the change by removing the exports. At the least, we should wait to add them until a major version. In the meantime, we will have further discussion about what the best solution is going forward for all validator directives. Closes angular#17491. ---- PR angular#17551 tried to roll this back, but did not remove the dead code. This failed internal tests that were checking that all declared directives were used. This PR rolls back the original PR and commit the same as angular#17551 while also removing the dead code.
toString() from DefaultKeyValueDiffer is only used in tests and should not be part of the production code. toString() methods from differs add ~ 0.3KB (min+gzip) to the production bundle size.
Destructuring of the form:
function foo({a, b}: {a?, b?} = {})
breaks strictNullChecks, due to the TypeScript bug microsoft/TypeScript#10078.
This change eliminates usage of destructuring in function argument lists in cases where it would leak
into the public API .d.ts.
This list renders OK in the github UI but not at https://angular.io/guide/testing#setup
closes angular#17656 also adds test for ContributorListComponent.
It is not possible to run all the docs tests directly via the jasmine CLI. Instead we now have a small script that will run jasmine via its library.
Running the patch script on Windows (with `patch` available) yields an invalid syntax warning, and does not apply patches. ``` kamik@T460p MINGW64 /d/work/angular/aio (master) $ yarn postinstall yarn postinstall v0.24.6 $ node tools/cli-patches/patch.js && uglifyjs node_modules/lunr/lunr.js -c -m -o src/assets/js/lunr.min.js --source-map The syntax of the command is incorrect. Done in 1.52s. ```
With https:// the site gives console errors, because it loads fonts with http://
This reverts commit 1bf7ba8. The commit caused master builds to fail with: ``` $ scripts/payload.sh error Command failed with exit code 1. error Command failed with exit code 1. ``` https://travis-ci.org/angular/angular/jobs/253405260#L1024
This reverts commit 72143e8. it seems that the previous build failure was a travis flake. reverting the revert...
wKoza
force-pushed
the
cleanup_common_http
branch
from
ab590d1
to
59f10c7
Compare
wKoza
force-pushed
the
cleanup_common_http
branch
from
59f10c7
to
47c258f
Compare
mhevery
pushed a commit
that referenced
this pull request
Jul 26, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a cleaning of imports of the new module HttpClient