Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform-server): don't clobber parse5 properties when setting #18237

Closed
wants to merge 1 commit into from
Closed

fix(platform-server): don't clobber parse5 properties when setting #18237

wants to merge 1 commit into from

Conversation

vikerman
Copy link
Contributor

element properties.

Fixes #17050.

We now store all element properties in a separate 'properties' bag.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Setting properties like "name" on an element in platform-server will cause the rendered HTML string to have invalid tag names for the element.

Issue Number: 17050

What is the new behavior?

Setting any property on the element wouldn't cause serialization to string to break.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@mary-poppins
Copy link

You can preview 3cf275d at https://pr18237-3cf275d.ngbuilds.io/.

Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should have a discussion on whether or not to consider this breaking.

@vikerman
Copy link
Contributor Author

The plan is to merge to master and ask our Universal customers whether it would be breaking for them if we moved this to the stable branch.

@mary-poppins
Copy link

You can preview df7258f at https://pr18237-df7258f.ngbuilds.io/.

element properties.

Fixes #17050.

We now store all element properties in a separate 'properties' bag.
@vikerman vikerman added the action: merge The PR is ready for merge by the caretaker label Jul 20, 2017
@mary-poppins
Copy link

You can preview f5b6d61 at https://pr18237-f5b6d61.ngbuilds.io/.

@mhevery mhevery closed this in a094769 Jul 20, 2017
mhevery pushed a commit that referenced this pull request Jul 26, 2017
…18237)

element properties.

Fixes #17050.

We now store all element properties in a separate 'properties' bag.

PR Close #18237
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…ngular#18237)

element properties.

Fixes angular#17050.

We now store all element properties in a separate 'properties' bag.

PR Close angular#18237
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
…ngular#18237)

element properties.

Fixes angular#17050.

We now store all element properties in a separate 'properties' bag.

PR Close angular#18237
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…ngular#18237)

element properties.

Fixes angular#17050.

We now store all element properties in a separate 'properties' bag.

PR Close angular#18237
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting name property on any element causes exception on server side rendering
5 participants