-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(platform-server): don't clobber parse5 properties when setting #18237
Conversation
You can preview 3cf275d at https://pr18237-3cf275d.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should have a discussion on whether or not to consider this breaking.
The plan is to merge to master and ask our Universal customers whether it would be breaking for them if we moved this to the stable branch. |
You can preview df7258f at https://pr18237-df7258f.ngbuilds.io/. |
element properties. Fixes #17050. We now store all element properties in a separate 'properties' bag.
You can preview f5b6d61 at https://pr18237-f5b6d61.ngbuilds.io/. |
…ngular#18237) element properties. Fixes angular#17050. We now store all element properties in a separate 'properties' bag. PR Close angular#18237
…ngular#18237) element properties. Fixes angular#17050. We now store all element properties in a separate 'properties' bag. PR Close angular#18237
…ngular#18237) element properties. Fixes angular#17050. We now store all element properties in a separate 'properties' bag. PR Close angular#18237
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
element properties.
Fixes #17050.
We now store all element properties in a separate 'properties' bag.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Setting properties like "name" on an element in platform-server will cause the rendered HTML string to have invalid tag names for the element.
Issue Number: 17050
What is the new behavior?
Setting any property on the element wouldn't cause serialization to string to break.
Does this PR introduce a breaking change?