Drop use of the Intl API to improve browser support #18284

ocombe · 2017-07-21T18:14:05Z

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature

What is the current behavior?

We need the intl API for i18n pipes

Issue Number: #10809, #9524, #7008, #9324, #7590, #6724, #3429, #17576, #17478, #17319, #17200, #16838, #16624, #16625, #16591, #14131, #12632, #11376, #11187

What is the new behavior?

We don't need the intl API anymore, we extract and use data from CLDR instead.

Date pipe:

new formats (breaking change), see comparative document
new optional parameter: timezone that lets you specify the timezone for a date (it will shift the date values based on the locale timezone so that you see it as it was from this other timezone).
new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Plural pipe:

new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Decimal pipe:

new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Percent pipe:

new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Currency pipe:

the parameter symbolDisplay is no longer a boolean (it still works with a boolean, but it prints a warning to let you know that it changed), it’s now taking the values code, symbol, or symbol-narrow (the default is still code) which gives you access to more options for to show your currencies (e.g. the canadian dollar with the code CAD has the symbol CA$ and the symbol-narrow $).
new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Does this PR introduce a breaking change?

[x] Yes

All i18n pipes have been updated to not require the intl API anymore. Some results might vary, see the document to update from v4 to v5 for more information.

TODO

write a document to update from v4 to v5

vicb · 2017-07-21T18:39:49Z

tools/gulp-tasks/cldr/extract.js

+
+  const dateTimeTranslations = {dayPeriodsFormat, daysFormat, monthsFormat, eras};
+
+  if(dayPeriodsFormat !== dayPeriodsStandalone) {


add comment on dedup

vicb · 2017-07-21T23:08:35Z

packages/common/src/i18n/localization.ts

+ * ie: "en-US" will return "en", and "fr_ca" will return "fr-CA"
+ */
+function getNormalizedLocale(locale: string): string {
+  const normalizedLocale = locale.toLowerCase().replace(new RegExp('_', 'g'), '-');


nit: new RegExp('_', 'g') -> /-/g

vicb · 2017-07-21T23:12:53Z

packages/common/src/i18n/localization.ts

+ * @experimental i18n support is experimental.
+ */
+export function findNgLocale(locale: string, localeData: NgLocale[] | null): NgLocale {
+  const currentLocale = getNormalizedLocale(locale);


currentLocale -> normalizedLocale

vicb · 2017-07-21T23:17:24Z

packages/platform-browser/test/browser_util_spec.ts

@@ -234,7 +234,6 @@ export function main() {
        expect(bd.isIOS7).toBe(browser['isIOS7']);
        expect(bd.isSlow).toBe(browser['isSlow']);
        expect(bd.isChromeDesktop).toBe(browser['isChromeDesktop']);
-        expect(bd.isOldChrome).toBe(browser['isOldChrome']);


why this change ?

isOldChrome is only used by intl api, when I first did the PR, I removed the old pipes and the tests for them. But then I moved them as deprecated pipes instead, and forgot to revert this change. Doing it now.

mary-poppins · 2017-07-25T20:49:56Z

You can preview 052a61a at https://pr18284-052a61a.ngbuilds.io/.

vicb · 2017-07-25T23:43:03Z

tools/gulp-tasks/cldr/extract.js

+ * found in the LICENSE file at https://angular.io/license
+ */
+
+// This is generated code DO NOT MODIFY


THIS CODE IS GENERATED - DO NOT MODIFY

vicb · 2017-07-25T23:49:49Z

packages/common/i18n/full/locale_af-NA.ts

+const format = NgLocaleAfNA.dateTime.translations.dayPeriods.format;
+const std = NgLocaleAfNA.dateTime.translations.dayPeriods.standalone;
+
+format.narrow = {...format.narrow, ...dpF.narrow};


Thoughts:

I think we can remove all of the {..., ...},

I think we can also remove the need to import the std objects and merge the full object

Because we are going to use an API to access the data (which goal is to abstract the storage format).

Also the registerLocaleData(...) could help here.

vicb · 2017-07-25T23:51:12Z

tools/gulp-tasks/cldr/extract.js

+    settings: ${getDateTimeSettings(localeData)}
+  },
+  number: {
+    settings: ${getNumberSettings(localeData)}


do we need a nested key here and below ?

not yet, just thinking about future things that we might add

vicb · 2017-07-25T23:51:53Z

tools/gulp-tasks/cldr/extract.js

+  const dpF = stringify(dayPeriods.format);
+  let dpStd = stringify(dayPeriods['stand-alone']);
+
+  if (dpF === dpStd) {


add a comment explaining what you do pls

vicb · 2017-07-25T23:52:53Z

tools/gulp-tasks/cldr/extract.js

+
+const dpF = ${dpF};${dpStd ? `\nconst dpStd = ${dpStd};` : ''}
+
+const format = NgLocale${toPascalCase(locale)}.dateTime.translations.dayPeriods.format;


There is probably no need to duplicate this logic as many time as we have locales

vicb · 2017-07-25T23:53:42Z

tools/gulp-tasks/cldr/extract.js

+  const dayPeriodsStandalone = stringify(dayPeriods['stand-alone']);
+
+  const daysFormat = stringify({
+    narrow: objectValues(dayNames.format.narrow),


Have you tried to generate arrays instead of obj ?
What is the diff in size ?

vicb · 2017-07-25T23:57:35Z

packages/common/i18n/full/locale_ar-QA.ts

@@ -0,0 +1,94 @@
+/**


Idea: I donc speak ar but the files look really similar for different regions (the QA part). Is there any check in place to make sure we do not duplicate the same data multiple times ?

Not between different locales no, but it doesn't really matter since people will only import one of them, not all

It will prevent devs to have to buy a new SSD only to npm install Angular.
The check is easy enough. Please git it a try to see how much we can save.

vicb · 2017-07-26T00:00:17Z

packages/common/i18n/locale_fr-BJ.ts

+// This is generated code DO NOT MODIFY
+// See angular/tools/gulp-tasks/cldr/extract.js
+
+import {LOCALE_DATA, NgLocale, Plural} from '@angular/common';


meme remarque encore ici: probablement beaucoup de chose en commun avec fr-* (sauf currency et peut etre numbers). Would be NICE to check what we can factor.

vicb · 2017-07-26T00:01:34Z

packages/common/src/i18n/currencies.ts

+
+/** @experimental */
+export const CURRENCIES: {[code: string]: {[key: string]: string}} = {
+  'ADP': {symbol: 'ADP'},


An array would make sense here instead of an obj.

👍 Just saved 6.2ko minified by optimizing this file!

mary-poppins · 2017-08-21T15:49:48Z

You can preview 3ae3d61 at https://pr18284-3ae3d61.ngbuilds.io/.

mary-poppins · 2017-08-21T17:26:20Z

You can preview 9613115 at https://pr18284-9613115.ngbuilds.io/.

vicb · 2017-08-22T18:25:44Z

packages/common/src/common.ts

@@ -14,7 +14,7 @@
 export * from './location/index';
 export {NgLocaleLocalization, NgLocalization} from './i18n/localization';
 export {Plural, LOCALE_DATA} from './i18n/locale_data';
-export {findLocaleData, registerLocaleData, NumberFormatStyle, FormStyle, Time, TranslationWidth, FormatWidth, NumberSymbol, WeekDay, getLocaleDayPeriods, getLocaleDayNames, getLocaleMonthNames, getLocaleId, getLocaleEraNames, getLocaleWeekEndRange, getLocaleFirstDayOfWeek, getLocaleDateFormat, getLocaleDateTimeFormat, getLocaleExtraDayPeriodRules, getLocaleExtraDayPeriods, getLocalePluralCase, getLocaleTimeFormat, getLocaleNumberSymbol, getLocaleNumberFormat, getLocaleCurrencyName, getLocaleCurrencySymbol} from './i18n/locale_data_api';


@NgModule

BREAKING CHANGE: Because of multiple bugs and browser inconsistencies, we have dropped the intl api in favor of data exported from the Unicode Common Locale Data Repository (CLDR). Unfortunately we had to change the i18n pipes (date, number, currency, percent) and there are some breaking changes. 1. I18n pipes * Breaking change: - By default Angular now only contains locale data for the language `en-US`, if you set the value of `LOCALE_ID` to another locale, you will have to import new locale data for this language because we don't use the intl API anymore. * Features: - you don't need to use the intl polyfill for Angular anymore. - all i18n pipes now have an additional last parameter `locale` which allows you to use a specific locale instead of the one defined in the token `LOCALE_ID` (whose value is `en-US` by default). - the new locale data extracted from CLDR are now available to developers as well and can be used through an API (which should be especially useful for library authors). - you can still use the old pipes for now, but their names have been changed and they are no longer included in the `CommonModule`. To use them, you will have to import the `DeprecatedI18NPipesModule` after the `CommonModule` (the order is important): ```ts import { NgModule } from '@angular/core'; import { CommonModule, DeprecatedI18NPipesModule } from '@angular/common'; @NgModule({ imports: [ CommonModule, // import deprecated module after DeprecatedI18NPipesModule ] }) export class AppModule { } ``` Dont forget that you will still need to import the intl API polyfill if you want to use those deprecated pipes. 2. Date pipe * Breaking changes: - the predefined formats (`short`, `shortTime`, `shortDate`, `medium`, ...) now use the patterns given by CLDR (like it was in AngularJS) instead of the ones from the intl API. You might notice some changes, e.g. `shortDate` will be `8/15/17` instead of `8/15/2017` for `en-US`. - the narrow version of eras is now `GGGGG` instead of `G`, the format `G` is now similar to `GG` and `GGG`. - the narrow version of months is now `MMMMM` instead of `L`, the format `L` is now the short standalone version of months. - the narrow version of the week day is now `EEEEE` instead of `E`, the format `E` is now similar to `EE` and `EEE`. - the timezone `z` will now fallback to `O` and output `GMT+1` instead of the complete zone name (e.g. `Pacific Standard Time`), this is because the quantity of data required to have all the zone names in all of the existing locales is too big. - the timezone `Z` will now output the ISO8601 basic format, e.g. `+0100`, you should now use `ZZZZ` to get `GMT+01:00`. | Field type | Format | Example value | v4 | v5 | |------------|---------------|-----------------------|----|---------------| | Eras | Narrow | A for AD | G | GGGGG | | Months | Narrow | S for September | L | MMMMM | | Week day | Narrow | M for Monday | E | EEEEE | | Timezone | Long location | Pacific Standard Time | z | Not available | | Timezone | Long GMT | GMT+01:00 | Z | ZZZZ | * Features - new predefined formats `long`, `full`, `longTime`, `fullTime`. - the format `yyy` is now supported, e.g. the year `52` will be `052` and the year `2017` will be `2017`. - standalone months are now supported with the formats `L` to `LLLLL`. - week of the year is now supported with the formats `w` and `ww`, e.g. weeks `5` and `05`. - week of the month is now supported with the format `W`, e.g. week `3`. - fractional seconds are now supported with the format `S` to `SSS`. - day periods for AM/PM now supports additional formats `aa`, `aaa`, `aaaa` and `aaaaa`. The formats `a` to `aaa` are similar, while `aaaa` is the wide version if available (e.g. `ante meridiem` for `am`), or equivalent to `a` otherwise, and `aaaaa` is the narrow version (e.g. `a` for `am`). - extra day periods are now supported with the formats `b` to `bbbbb` (and `B` to `BBBBB` for the standalone equivalents), e.g. `morning`, `noon`, `afternoon`, .... - the short non-localized timezones are now available with the format `O` to `OOOO`. The formats `O` to `OOO` will output `GMT+1` while the format `OOOO` will be `GMT+01:00`. - the ISO8601 basic time zones are now available with the formats `Z` to `ZZZZZ`. The formats `Z` to `ZZZ` will output `+0100`, while the format `ZZZZ` will be `GMT+01:00` and `ZZZZZ` will be `+01:00`. * Bug fixes - the date pipe will now work exactly the same across all browsers, which will fix a lot of bugs for safari and IE. - eras can now be used on their own without the date, e.g. the format `GG` will be `AD` instead of `8 15, 2017 AD`. 3. Currency pipe * Breaking change: - the default value for `symbolDisplay` is now `symbol` instead of `code`. This means that by default you will see `$4.99` for `en-US` instead of `USD4.99` previously. * Deprecation: - the second parameter of the currency pipe (`symbolDisplay`) is no longer a boolean, it now takes the values `code`, `symbol` or `symbol-narrow`. A boolean value is still valid for now, but it is deprecated and it will print a warning message in the console. * Features: - you can now choose between `code`, `symbol` or `symbol-narrow` which gives you access to more options for some currencies (e.g. the canadian dollar with the code `CAD` has the symbol `CA$` and the symbol-narrow `$`). 4. Percent pipe * Breaking change - if you don't specify the number of digits to round to, the local format will be used (and it usually rounds numbers to 0 digits, instead of not rounding previously), e.g. `{{ 3.141592 | percent }}` will output `314%` for the locale `en-US` instead of `314.1592%` previously. Fixes angular#10809, angular#9524, angular#7008, angular#9324, angular#7590, angular#6724, angular#3429, angular#17576, angular#17478, angular#17319, angular#17200, angular#16838, angular#16624, angular#16625, angular#16591, angular#14131, angular#12632, angular#11376, angular#11187

PR Close #18284

@NgModule

…8284) BREAKING CHANGE: Because of multiple bugs and browser inconsistencies, we have dropped the intl api in favor of data exported from the Unicode Common Locale Data Repository (CLDR). Unfortunately we had to change the i18n pipes (date, number, currency, percent) and there are some breaking changes. 1. I18n pipes * Breaking change: - By default Angular now only contains locale data for the language `en-US`, if you set the value of `LOCALE_ID` to another locale, you will have to import new locale data for this language because we don't use the intl API anymore. * Features: - you don't need to use the intl polyfill for Angular anymore. - all i18n pipes now have an additional last parameter `locale` which allows you to use a specific locale instead of the one defined in the token `LOCALE_ID` (whose value is `en-US` by default). - the new locale data extracted from CLDR are now available to developers as well and can be used through an API (which should be especially useful for library authors). - you can still use the old pipes for now, but their names have been changed and they are no longer included in the `CommonModule`. To use them, you will have to import the `DeprecatedI18NPipesModule` after the `CommonModule` (the order is important): ```ts import { NgModule } from '@angular/core'; import { CommonModule, DeprecatedI18NPipesModule } from '@angular/common'; @NgModule({ imports: [ CommonModule, // import deprecated module after DeprecatedI18NPipesModule ] }) export class AppModule { } ``` Dont forget that you will still need to import the intl API polyfill if you want to use those deprecated pipes. 2. Date pipe * Breaking changes: - the predefined formats (`short`, `shortTime`, `shortDate`, `medium`, ...) now use the patterns given by CLDR (like it was in AngularJS) instead of the ones from the intl API. You might notice some changes, e.g. `shortDate` will be `8/15/17` instead of `8/15/2017` for `en-US`. - the narrow version of eras is now `GGGGG` instead of `G`, the format `G` is now similar to `GG` and `GGG`. - the narrow version of months is now `MMMMM` instead of `L`, the format `L` is now the short standalone version of months. - the narrow version of the week day is now `EEEEE` instead of `E`, the format `E` is now similar to `EE` and `EEE`. - the timezone `z` will now fallback to `O` and output `GMT+1` instead of the complete zone name (e.g. `Pacific Standard Time`), this is because the quantity of data required to have all the zone names in all of the existing locales is too big. - the timezone `Z` will now output the ISO8601 basic format, e.g. `+0100`, you should now use `ZZZZ` to get `GMT+01:00`. | Field type | Format | Example value | v4 | v5 | |------------|---------------|-----------------------|----|---------------| | Eras | Narrow | A for AD | G | GGGGG | | Months | Narrow | S for September | L | MMMMM | | Week day | Narrow | M for Monday | E | EEEEE | | Timezone | Long location | Pacific Standard Time | z | Not available | | Timezone | Long GMT | GMT+01:00 | Z | ZZZZ | * Features - new predefined formats `long`, `full`, `longTime`, `fullTime`. - the format `yyy` is now supported, e.g. the year `52` will be `052` and the year `2017` will be `2017`. - standalone months are now supported with the formats `L` to `LLLLL`. - week of the year is now supported with the formats `w` and `ww`, e.g. weeks `5` and `05`. - week of the month is now supported with the format `W`, e.g. week `3`. - fractional seconds are now supported with the format `S` to `SSS`. - day periods for AM/PM now supports additional formats `aa`, `aaa`, `aaaa` and `aaaaa`. The formats `a` to `aaa` are similar, while `aaaa` is the wide version if available (e.g. `ante meridiem` for `am`), or equivalent to `a` otherwise, and `aaaaa` is the narrow version (e.g. `a` for `am`). - extra day periods are now supported with the formats `b` to `bbbbb` (and `B` to `BBBBB` for the standalone equivalents), e.g. `morning`, `noon`, `afternoon`, .... - the short non-localized timezones are now available with the format `O` to `OOOO`. The formats `O` to `OOO` will output `GMT+1` while the format `OOOO` will be `GMT+01:00`. - the ISO8601 basic time zones are now available with the formats `Z` to `ZZZZZ`. The formats `Z` to `ZZZ` will output `+0100`, while the format `ZZZZ` will be `GMT+01:00` and `ZZZZZ` will be `+01:00`. * Bug fixes - the date pipe will now work exactly the same across all browsers, which will fix a lot of bugs for safari and IE. - eras can now be used on their own without the date, e.g. the format `GG` will be `AD` instead of `8 15, 2017 AD`. 3. Currency pipe * Breaking change: - the default value for `symbolDisplay` is now `symbol` instead of `code`. This means that by default you will see `$4.99` for `en-US` instead of `USD4.99` previously. * Deprecation: - the second parameter of the currency pipe (`symbolDisplay`) is no longer a boolean, it now takes the values `code`, `symbol` or `symbol-narrow`. A boolean value is still valid for now, but it is deprecated and it will print a warning message in the console. * Features: - you can now choose between `code`, `symbol` or `symbol-narrow` which gives you access to more options for some currencies (e.g. the canadian dollar with the code `CAD` has the symbol `CA$` and the symbol-narrow `$`). 4. Percent pipe * Breaking change - if you don't specify the number of digits to round to, the local format will be used (and it usually rounds numbers to 0 digits, instead of not rounding previously), e.g. `{{ 3.141592 | percent }}` will output `314%` for the locale `en-US` instead of `314.1592%` previously. Fixes #10809, #9524, #7008, #9324, #7590, #6724, #3429, #17576, #17478, #17319, #17200, #16838, #16624, #16625, #16591, #14131, #12632, #11376, #11187 PR Close #18284

BREAKING CHANGE: In v5, we deprecated support for the intl API in order to improve the browser support. We are now removing these deprecated APIs for v8. See the original change here for more info on why: angular#18284.

angular-automatic-lock-bot · 2019-09-12T20:51:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

ocombe added area: i18n state: WIP labels Jul 21, 2017

ocombe requested review from IgorMinar and vicb July 21, 2017 18:14

googlebot added the cla: yes label Jul 21, 2017

ocombe changed the title ~~Fix intl api 10809~~ feat(core): remove dependency to intl API Jul 21, 2017

vicb reviewed Jul 21, 2017

View reviewed changes

ocombe force-pushed the fix-intl-api-10809 branch 3 times, most recently from 1053613 to d513368 Compare July 25, 2017 19:24

angular deleted a comment from mary-poppins Jul 25, 2017

ocombe force-pushed the fix-intl-api-10809 branch from d513368 to c33247f Compare July 25, 2017 19:59

angular deleted a comment from mary-poppins Jul 25, 2017

ocombe force-pushed the fix-intl-api-10809 branch from c33247f to 052a61a Compare July 25, 2017 20:31

angular deleted a comment from mary-poppins Jul 25, 2017

vicb reviewed Jul 25, 2017

View reviewed changes

vicb reviewed Jul 26, 2017

View reviewed changes

ocombe mentioned this pull request Aug 21, 2017

CurrencyPipe tests failing on chrome mobile #18807

Closed

1 task

ocombe force-pushed the fix-intl-api-10809 branch from 591dea5 to 3ae3d61 Compare August 21, 2017 15:42

ocombe added 2 commits August 21, 2017 19:03

build(common): extract i18n locale data from cldr

96ec783

build(common): add generated i18n locale data files

80d556a

ocombe force-pushed the fix-intl-api-10809 branch from 3ae3d61 to 9613115 Compare August 21, 2017 17:19

ocombe mentioned this pull request Aug 21, 2017

feat(common): generate i18n data file locale_all file for closure #18813

Closed

ocombe force-pushed the fix-intl-api-10809 branch from 9613115 to af9b055 Compare August 22, 2017 18:23

vicb reviewed Aug 22, 2017

View reviewed changes

ocombe force-pushed the fix-intl-api-10809 branch from af9b055 to fcb32a1 Compare August 22, 2017 18:28

ocombe force-pushed the fix-intl-api-10809 branch from fcb32a1 to 6dc6dd5 Compare August 22, 2017 18:32

mhevery approved these changes Aug 22, 2017

View reviewed changes

mhevery added the action: merge The PR is ready for merge by the caretaker label Aug 22, 2017

mhevery pushed a commit that referenced this pull request Aug 22, 2017

build(common): add generated i18n locale data files (#18284)

a73389b

PR Close #18284

mhevery closed this in 33d250f Aug 22, 2017

ericsvendsen mentioned this pull request Aug 30, 2017

p-calendar doesn't display correct date when utc="true" primefaces/primeng#3611

Closed

ocombe deleted the fix-intl-api-10809 branch November 10, 2017 08:48

ocombe mentioned this pull request Mar 7, 2019

Use correct plural form for ivy #29160

Closed

ocombe mentioned this pull request Mar 12, 2019

fix(common): remove deprecated support for intl API #29250

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop use of the Intl API to improve browser support #18284

Drop use of the Intl API to improve browser support #18284

ocombe commented Jul 21, 2017 •

edited

Loading

vicb Jul 21, 2017

vicb Jul 21, 2017

vicb Jul 21, 2017

vicb Jul 21, 2017

ocombe Jul 24, 2017

mary-poppins commented Jul 25, 2017

vicb Jul 25, 2017

vicb Jul 25, 2017

vicb Jul 25, 2017

ocombe Jul 26, 2017

vicb Jul 25, 2017

vicb Jul 25, 2017

vicb Jul 25, 2017

vicb Jul 25, 2017

ocombe Jul 26, 2017

vicb Jul 26, 2017

vicb Jul 26, 2017

vicb Jul 26, 2017

ocombe Jul 26, 2017 •

edited

Loading

mary-poppins commented Aug 21, 2017

mary-poppins commented Aug 21, 2017

vicb Aug 22, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019


		const dateTimeTranslations = {dayPeriodsFormat, daysFormat, monthsFormat, eras};

		if(dayPeriodsFormat !== dayPeriodsStandalone) {


		const dpF = ${dpF};${dpStd ? `\nconst dpStd = ${dpStd};` : ''}

		const format = NgLocale${toPascalCase(locale)}.dateTime.translations.dayPeriods.format;

Drop use of the Intl API to improve browser support #18284

Drop use of the Intl API to improve browser support #18284

Conversation

ocombe commented Jul 21, 2017 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

Date pipe:

Plural pipe:

Decimal pipe:

Percent pipe:

Currency pipe:

Does this PR introduce a breaking change?

TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mary-poppins commented Jul 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocombe Jul 26, 2017 • edited Loading

Choose a reason for hiding this comment

mary-poppins commented Aug 21, 2017

mary-poppins commented Aug 21, 2017

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 12, 2019

ocombe commented Jul 21, 2017 •

edited

Loading

ocombe Jul 26, 2017 •

edited

Loading