Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular does not compile cleanly with TypeScript 2.4 #18454

Closed
chuckjaz opened this issue Aug 1, 2017 · 9 comments
Closed

Angular does not compile cleanly with TypeScript 2.4 #18454

chuckjaz opened this issue Aug 1, 2017 · 9 comments
Assignees
Labels
area: core Issues related to the framework runtime freq2: medium type: bug/fix
Milestone

Comments

@chuckjaz
Copy link
Contributor

chuckjaz commented Aug 1, 2017

I'm submitting a...


[x] Bug report  

Current behavior

With stricter checking and improved type inference, TypeScript 2.4 now reports errors in Angular that are not reported in 2.3.

This also produces .d.ts files that are reported as errors by 2.4 as reported here:

#17863
#17522

Expected behavior

Angular compiles cleanly with 2.4.

Minimal reproduction of the problem with instructions

Upgrade TypeScript to 2.4 and run build.sh.

@danwulff
Copy link

danwulff commented Sep 1, 2017

Was this fixed with 4.3.4? #18456
image

@chuckjaz
Copy link
Contributor Author

chuckjaz commented Sep 4, 2017

Not yet. There were a number of improvements but not all of the PRs have landed yet nor have all of them been merged with the 4.3.x branch.

@xnnkmd
Copy link

xnnkmd commented Sep 13, 2017

@chuckjaz Of all the planned features for newer versions of angular, this is really what I want the most. Any idea of when Angular will work with newest typescript (2.5 currently) ?

@kiwikern
Copy link

Typescript 2.4.2 is supported now with Angular 5

@xnnkmd
Copy link

xnnkmd commented Nov 13, 2017

Typescript 2.4.2 is yesterdays news by now....Now we just need typescript 2.6 support :-)

@chuckjaz
Copy link
Contributor Author

We need a change to Tsickle to support both 2.4 and 2.5 for us to be able to shift our dependency to a version of Tsickle we can use. We are working on that now. Hopefully we should get this into this weeks release. If not it should be next week.

@chuckjaz
Copy link
Contributor Author

BTW, this is only for 2.5 support. We are still working to valid 2.6.

@IgorMinar
Copy link
Contributor

this is now obsolete

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime freq2: medium type: bug/fix
Projects
None yet
Development

No branches or pull requests

6 participants