Update RxJS dependency

[avatsaev]

Description

Doesn't work with Angular 4.3 & Angular CLI 1.4.1

Expected Behavior

Actual Behavior

Error at compile time

ERROR in node_modules/videogular2/node_modules/rxjs/Subject.d.ts (16,22): Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
  Types of property 'lift' are incompatible.
  Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
    Type 'Observable<T>' is not assignable to type 'Observable<R>'.
      Type 'T' is not assignable to type 'R'.
      ERROR in node_modules/videogular2/src/core/vg-media/i-playable.d.ts (1,23): Cannot find type definition file for 'core-js'.
      ERROR in node_modules/videogular2/src/core/vg-media/vg-media.d.ts (1,23): Cannot find type definition file for 'core-js'.
      ERROR in node_modules/videogular2/src/core/services/vg-api.d.ts (1,23): Cannot find type definition file for 'core-js'.

Steps to Reproduce

If this is an issue, describe the steps you took to see the issue. If this is a feature, delete this block.

1. Step 1
2. Step 2

Attachments

Try to include screenshots for bugs or design assets for enhancements

Image Title
(https://media.giphy.com/media/143vPc6b08locw/giphy.gif)
Image description

[nickyxu]

hi avatsaev,
I meet the same problem. Have you fixed it? Or, any solution?

[nickyxu]

Hi,
It works!
My solution is:

1. Downgrade the rxjs to V5.1.0
2. Downgrade the typescript to V2.3.4

[avatsaev]

Hey @nickyxu, I just disabled type checking for libraries in my tsconfig, a little radical I know, but it works

  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "skipLibCheck": true,

[bopm]

After some help from @Elecash with pointing out that any combination of libs not breaking that in https://github.com/videogular/videogular2-showroom/ I was able to fix the same problem by removing my local yarn.lock on my project and reinstall all dependencies. I guess same will work for package-lock.json too.

[Elecash]

I can confirm that it worked for me by deleting the package-lock.json.

[avatsaev]

Still experiencing errors when building with libCheck option:

TS 2.5
Angular 4.4
RxJS : 5.4

ERROR in node_modules/videogular2/node_modules/rxjs/Subject.d.ts (16,22): Class 'Subject<T>' incorrectly extends base class 'Observable<T>'.
Types of property 'lift' are incompatible.
Type '<R>(operator: Operator<T, R>) => Observable<T>' is not assignable to type '<R>(operator: Operator<T, R>) => Observable<R>'.
Type 'Observable<T>' is not assignable to type 'Observable<R>'.
Type 'T' is not assignable to type 'R'.

[bopm]

@avatsaev according to that there is no Angular 4 support for TS version bigger than 2.3 and never will be.

[avatsaev]

Yep, that turned out to be the problem, thank you.