Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animations): do not leak DOM nodes/styling for host triggered animations #18853

Closed
wants to merge 1 commit into from
Closed

fix(animations): do not leak DOM nodes/styling for host triggered animations #18853

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Aug 23, 2017

Closes #18606

@mary-poppins
Copy link

You can preview c3c51da at https://pr18853-c3c51da.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 40be6a2 at https://pr18853-40be6a2.ngbuilds.io/.

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2017
@jasonaden jasonaden added the target: patch This PR is targeted for the next patch release label Aug 29, 2017
This was referenced Aug 30, 2017
Closed
Closed
@jasonaden jasonaden closed this in fcadeb2 Sep 1, 2017
jasonaden pushed a commit that referenced this pull request Sep 1, 2017
@matsko @jasonaden
fix(animations): do not leak DOM nodes/styling for host triggered ani…
1cc3fe2 
…mations (#18853)

Closes #18606

PR Close #18853
@matsko matsko deleted the fix_double_host_issue branch September 1, 2017 18:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dom nodes memory leak with animations using @HostBinding
5 participants
@matsko @mary-poppins @mhevery @jasonaden @googlebot