Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(compiler): update i18n comments deprecation message #19215

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Sep 15, 2017

PR Type

What kind of change does this PR introduce?

[x] Refactoring (no functional changes, no api changes)

What is the current behavior?

When my previous PR (#18998) was merged it didn't take my last changes to the code into account.

What is the new behavior?

Fixed message for the i18n comments deprecation

Does this PR introduce a breaking change?

[x] No

@mary-poppins
Copy link

You can preview 09d329f at https://pr19215-09d329f.ngbuilds.io/.

@vicb vicb added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Sep 15, 2017
@IgorMinar IgorMinar closed this in bc0750e Sep 20, 2017
@ocombe ocombe deleted the deprecate-i18n-comments branch November 10, 2017 08:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants