-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters inside stagger() don't work #19786
Comments
Hi, can you link to a plunkr online demo? @matsko is this a known issue? |
I added a plunkr @manekinekko |
Thank you for bringing this up. I will get to a fix shortly. |
it's me or this not working :
then in template simply use |
Hi, Parameters inside stagger() don't work. When it would be fixed ? Thank's |
super sad sad face |
Please can this be fixed, I can't make re-usable animations for lists now. |
bump |
1 similar comment
bump |
BUUUMP. |
The entire Angular framework is on one side from being intuitive and reusable and simplicity and animation API is on another side. so so so unintuitive and unnecessarily complicated and weird. It's trying to follow functional programming while passing strings around as animation and I have to always look for examples because the docs make no sense and it's super tiring to read to be able to just create a simple fade animation with a variable passed in. |
@xe4me I won't say that it doesn't have positives but for some reason I feel like animations isn't part of Angular, it's like a whole new language that I have to learn and a whole new way of thinking, so it ads extra learning curve. |
Please keep your personal peeves out of this discussion. Angular animations is powerful and provides a ground for creating animations outside the scope of CSS. Even if its syntax is on the complex side (and you're welcome to suggest a better one), its still learnable and is highly useable (I use it incessantly in enterprise level apps).
This is a grossly wrong statement. Variables are supported, and they work well. If you read this issue properly you'd realize that people ask for animations parameters would be supported inside stagger() function too, which currently they are not.
Variables are not are not fundamental to "any animation library". Most frameworks provide APIs to create CSS animations. Angular animates DOM elements with timers, and not many frameworks provide this OTB. |
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves angular#19786
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves angular#19786
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves angular#19786
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves #19786 PR Close #47208
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves #19786 PR Close #47208
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly (this PR reinstates the changes done in angular#47208 which have been reverted because negative non-parametrized stagger values were not handled correctly, alongside the original changes the current commit also handles corretly negative non-parametrized values and improves unit testing) resolves angular#19786
prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly (this PR reinstates the changes done in angular#47208 which have been reverted because negative non-parametrized stagger values were not handled correctly, alongside the original changes the current commit also handles corretly negative non-parametrized values and improves unit testing) resolves angular#19786
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
When using an animation parameter inside stagger like
stagger('{{ delay }}', [
the animation fails, because the parameter is not replaced.Expected behavior
Parameters work inside stagger timings as well
Minimal reproduction of the problem with instructions
http://plnkr.co/edit/SqrTDLrYKNaL8hTYHESj?p=preview
Create a stagger animation with an parameter inside the staggers timing
What is the motivation / use case for changing the behavior?
Parameter replacement works on other timing properties, it should work in stagger as well.
Environment
The text was updated successfully, but these errors were encountered: