New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API docs are missing for HttpParamsOptions #20276
Comments
I was looking for this yesterday :) |
Any news? |
Just note that HttpParams doesn't add up to the previous params just like HttpSearchParams used to do. `let body = new HttpParams(); console.log(body.toString()); // will return null body = body.set('some_var', 'value'); console.log(body.toString()); //will return the params` |
fixed by #20332 |
@jbogarthyde To keep an eye on. :-) |
How's this progressing? |
@pickfire It means |
@trotyl Nice, I see what that means now. It definitely will be better in this case. |
How are things progressing on this issue? I noticed it was created in 2017 and till now it still produces same result. By result I mean, that https://angular.io/api/common/http/HttpParams references HttpParamsOptions type, but this type has no reference and therefore doesn't tell developer/user, what it provides/consists of. To find answers one needs to go https://github.com/angular/angular/blob/master/packages/common/http/src/params.ts#L113, but it is painful, when there are docs. |
The `HttpParamsOptions` was not documented or included in the public API even though it is a constructor argument of `HttpParams` which is a part of the public API. This commit adds the `HttpParamsOptions` into the exports, thus making it a part of the public API. Resolves angular#20276
This documentation is made more important by the fact that the default encoder doesn't work and you need to know how to override with a custom one. See #11058 |
The `HttpParamsOptions` was not documented or included in the public API even though it is a constructor argument of `HttpParams` which is a part of the public API. This commit adds the `HttpParamsOptions` into the exports, thus making it a part of the public API. Resolves angular#20276
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a...
Current behavior
HttpParams
is documented on Angular.io, however its constructor takesHttpParamsOptions
that doesn't link to a doc.Expected behavior
We could infer the shape of
HttpParamsOptions
from the source code, but it would be nice to describe, link to and search for it on the API portal.Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Environment
Angular 5.0.0
Others:
https://angular.io/api/common/http/
The text was updated successfully, but these errors were encountered: