Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): fix typo in filename (packages.json --> package.json) #20377

Closed
wants to merge 1 commit into from

Conversation

marcelosdm
Copy link
Contributor

@marcelosdm marcelosdm commented Nov 12, 2017

docs(aio): fix typo in filename (packages.json --> package.json)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@marcelosdm
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@marcelosdm marcelosdm changed the title fix the file name "package.json" docs(aio): file name fix Nov 12, 2017
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkalpak gkalpak added comp: docs action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Nov 13, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2017

Good catch, @marcelosdm! Can you please update the commit message to follow our guidelines? E.g. something like:

docs(aio): fix typo in filename (packages.json --> package.json)

@marcelosdm marcelosdm changed the title docs(aio): file name fix docs(aio): fix typo in filename (packages.json --> package.json) Nov 13, 2017
@marcelosdm
Copy link
Contributor Author

@gkalpak, thanks for the feedback!
I tried to change the commit message, but I don't know if I did it right. Could you please check it up?

@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2017

You have updated the PR title, but not the commit message 😃

I assume you have created the PR via the GitHub web-interface. In order to update the commit message, you would need to clone your fork of the repository on your machine, make the change and push again to GitHub (via the command-line or an app for managing git repositories).
It is a lot of work just for updating a commit message. (Things are much better if you already have cloned the repo and created the PR from your local machine.)

Let me do it for you. In case you are wondering, here is how you could do it via the command line:

# Clone your fork of the angular repository.
git clone https://github.com/marcelosdm/angular.git
cd angular

# Checkout the branch associated to this PR.
git fetch origin patch-2
git checkout -b patch-2 FETCH_HEAD

# Change the commit message.
git commit --amend
# ...an editor will open with the old commit message for you to edit and save...

# Push the changes back to GitHub.
git push --force-with-lease --set-upstream origin patch-2

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 13, 2017
@marcelosdm
Copy link
Contributor Author

@gkalpak thank you so much friend! Next time I'll be smart and clone the fork to my machine!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants