-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): fix typo in filename (packages.json --> package.json) #20377
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Good catch, @marcelosdm! Can you please update the commit message to follow our guidelines? E.g. something like:
|
@gkalpak, thanks for the feedback! |
You have updated the PR title, but not the commit message 😃 I assume you have created the PR via the GitHub web-interface. In order to update the commit message, you would need to clone your fork of the repository on your machine, make the change and push again to GitHub (via the command-line or an app for managing git repositories). Let me do it for you. In case you are wondering, here is how you could do it via the command line:
|
@gkalpak thank you so much friend! Next time I'll be smart and clone the fork to my machine! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
docs(aio): fix typo in filename (packages.json --> package.json)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information