Not possible to use Angular without Zone because of Router.setUpLocationChangeListener

[ArekSliwa]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

When using Angular Router it's not possible to use new Angular 5 feature ngZone: 'noop' .
In the console we can see: Zone is not defined error.
Router method setUpLocationChangeListener is using Zone.
screenshots:
zone is not defined
Router.setUpLocationChangeListener method implementation

Expected behavior

Angular Router is able to work without Zone.

Minimal reproduction of the problem with instructions

1. Just fire angular app with
   platformBrowserDynamic()
   .bootstrapModule(AppModule, {
   ngZone: 'noop'
   });
2. comment import 'zone.js/dist/zone'; in polyfills
3. Try to use angular Router in some easy case.

What is the motivation / use case for changing the behavior?

Environment

Angular version: 5.0.1



Browser:
- [x ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[JiaLiPassion]

@mhevery , should we provide a empty Zone implementation when use NgNoopZone?

such as for this issue,

if (!global['Zone']) {
  function NoopZone() {
    wrap(func) {
      return func;
    }
    ...
  }
  
  global['Zone'] = NoopZone;
  NoopZone.current = new NoopZone();
}

or provide a auto changeDetection version?

if (!global['Zone']) {
  function NoopZone() {
    wrap(func) {
      return function() {
        const result = func.apply(this, arguments);
        changeDetectRef.detectChange();
      } ;
    }
    ...
  }
  
  global['Zone'] = NoopZone;
  NoopZone.current = new NoopZone();
}

[mhevery]

@JiaLiPassion Instead of creating a noop mock, we should just remove that code from router. It seems like that 25e5b2f#diff-7f0963cbc503a361ded7d2bfec5f01b9R386 is there because zone.js does not properly patch the lociation.subscribe on the Rx. Given that now have a patch for Rx it does not seem like it is needed. Or rewrite the code in a way which does not need this???

[JiaLiPassion]

@mhevery , got it, I will look into it.

[ArekSliwa]

Thanks a lot for your attention to this issue! seems I can close it?

[JiaLiPassion]

@ArekSliwa, if my PR is correct, after merge , this issue will be closed automatically, thank you for posting the issue.

[me-12]

@JiaLiPassion Thank you for your PR. I am currently running into the same issue and was wondering if you could give an update on this issue. It looks like Travis is complaining about errors while testing.

[JiaLiPassion]

@me-12 , the travis is passed in the PR, do you mean some test failed in your travis build ?

[me-12]

@JiaLiPassion Sorry my bad. I was looking at your fork instead of the PR. #20640

So we are just waiting for @mhevery to review the PR again. Right?

[JiaLiPassion]

@me-12, yeah, I think so. please wait for a while.

[glebmachine]

Any news?

[glebmachine]

Wow, hope finally it works)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}