Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if providing a type annotation for ChangeDetector context is beneficial #2070

Closed
kegluneq opened this issue May 21, 2015 · 1 comment · Fixed by #2357
Closed

Determine if providing a type annotation for ChangeDetector context is beneficial #2070

kegluneq opened this issue May 21, 2015 · 1 comment · Fixed by #2357
Assignees
@kegluneq
Labels
effort2: days type: bug/fix
Milestone
alpha-27

Comments

@kegluneq
Copy link

Currently context is typed dynamic, but we have the information to fully type it.

This is a bit more complicated because it is assigned ChangeDetectionUtil.uninitialized when not hydrated, but we should be able to work around that.
@kegluneq kegluneq added feature Issue that requests a new feature #change_detection labels May 21, 2015
@kegluneq kegluneq self-assigned this May 21, 2015
@kegluneq kegluneq added this to the Performance Optimization milestone May 21, 2015
@mhevery mhevery added comp: #dart-transformer area: performance Issues related to performance and removed #dart/transformer labels May 29, 2015
@mhevery mhevery removed this from the Performance Optimization milestone May 29, 2015
@mhevery mhevery added type: bug/fix P2: required effort2: days and removed P3: important area: performance Issues related to performance feature Issue that requests a new feature labels May 29, 2015
@kegluneq kegluneq added this to the M10 milestone Jun 3, 2015
@kegluneq kegluneq self-assigned this Jun 3, 2015
@kegluneq kegluneq mentioned this issue Jun 4, 2015
Closed
kegluneq pushed a commit to kegluneq/angular that referenced this issue Jun 4, 2015
feat(dart/change_detect): Add type to ChangeDetector context
04547d7 
Add a type for the `context` field in Dart's pre-generated change
detectors. This requires slight changes to set the dehydrated value of
`context` to `null` rather than `ChangeDetectionUtil.uninitialized()`,
which was its former dehydrated state.

Mirror these chagnes as closely as possible in the
`ChangeDetectionJITGenerator` to allow easier maintenance.

Closes angular#2070
@kegluneq kegluneq mentioned this issue Jun 4, 2015
Merged
kegluneq pushed a commit to kegluneq/angular that referenced this issue Jun 4, 2015
feat(dart/change_detect): Add type to ChangeDetector context
bdcfdc7 
Add a type for the `context` field in Dart's pre-generated change
detectors. This requires slight changes to set the dehydrated value of
`context` to `null` rather than `ChangeDetectionUtil.uninitialized()`,
which was its former dehydrated state.

Mirror these chagnes as closely as possible in the
`ChangeDetectionJITGenerator` to allow easier maintenance.

Closes angular#2070
kegluneq pushed a commit to kegluneq/angular that referenced this issue Jun 5, 2015
feat(dart/change_detect): Add type to ChangeDetector context
5298055 
Add a type for the `context` field in Dart's pre-generated change
detectors. This requires slight changes to set the dehydrated value of
`context` to `null` rather than `ChangeDetectionUtil.uninitialized()`,
which was its former dehydrated state.

Mirror these chagnes as closely as possible in the
`ChangeDetectionJITGenerator` to allow easier maintenance.

Closes angular#2070
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kegluneq kegluneq

Labels
effort2: days type: bug/fix
Projects
None yet
Milestone
alpha-27
Development

Successfully merging a pull request may close this issue.

feat(dart/change_detect): Add type to ChangeDetector context kegluneq/angular
2 participants
@mhevery @kegluneq