Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service-worker): esm2015 points to wrong path #20800

Closed
wants to merge 1 commit into from
Closed

fix(service-worker): esm2015 points to wrong path #20800

wants to merge 1 commit into from

Conversation

Doehl
Copy link
Contributor

@Doehl Doehl commented Dec 5, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The Service Worker package points to a non-existing path for the esm2015 build.
Current value is "esm15"

This makes build with Google Closure Compiler impossible with following settings.
--package_json_entry_names es2015
--process_common_js_modules

Issue Number: N/A

What is the new behavior?

The esm2015 value should be "esm2015".

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

The package.json esm2015 points to the wrong path.
"esm15" should be "esm2015"

Service Worker can't be compiled with use of Closure Compiler
@IgorMinar IgorMinar added the area: service-worker Issues related to the @angular/service-worker package label Dec 5, 2017
@IgorMinar IgorMinar added this to the 5.0.x milestone Dec 5, 2017
@alxhub alxhub added the action: merge The PR is ready for merge by the caretaker label Dec 5, 2017
@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Dec 6, 2017
IgorMinar pushed a commit that referenced this pull request Dec 6, 2017
The package.json esm2015 points to the wrong path.
"esm15" should be "esm2015"

Service Worker can't be compiled with use of Closure Compiler
PR Close #20800
@IgorMinar IgorMinar closed this in da3563c Dec 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants