Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default_tsconfig on ts_repositories #20964

Closed
wants to merge 1 commit into from
Closed

Use default_tsconfig on ts_repositories #20964

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Dec 12, 2017 •
edited

This prevents us repeating the tsconfig attribute everywhere, and possibly having different tsconfig for different targets

@mary-poppins
Copy link

You can preview 0d0069b at https://pr20964-0d0069b.ngbuilds.io/.

@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Dec 12, 2017
@jasonaden jasonaden added the area: bazel Issues related to the published `@angular/bazel` build rules label Dec 12, 2017
@mary-poppins
Copy link

You can preview a13ce13 at https://pr20964-a13ce13.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 120962f at https://pr20964-120962f.ngbuilds.io/.

@alexeagle alexeagle force-pushed the default_tsconfig branch 2 times, most recently from 45ef942 to 34b886a Compare December 14, 2017 00:24
@mary-poppins
Copy link

You can preview 45ef942 at https://pr20964-45ef942.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 34b886a at https://pr20964-34b886a.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Dec 14, 2017
View reviewed changes
WORKSPACE Outdated

ts_repositories()
ts_setup_workspace(
default_tsconfig = "@angular_src//packages:tsconfig-build.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 14, 2017
@IgorMinar
Copy link
Contributor

@alexeagle CI is not happy, but that looks like a flake. Can you confirm?

@alexeagle alexeagle mentioned this pull request Dec 18, 2017
Closed
@alexeagle alexeagle force-pushed the default_tsconfig branch 4 times, most recently from c8133e4 to 5898c98 Compare January 9, 2018 18:05
@mary-poppins
Copy link

You can preview c8133e4 at https://pr20964-c8133e4.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5898c98 at https://pr20964-5898c98.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 37e1871 at https://pr20964-37e1871.ngbuilds.io/.

@alexeagle
build: move repeated tsconfig attributes to a macro
9a817ac 
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor
@mary-poppins
Copy link

You can preview 761eb0e at https://pr20964-761eb0e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 9a817ac at https://pr20964-9a817ac.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Jan 10, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproving to make pullapprove happy.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 10, 2018
alexeagle added a commit that referenced this pull request Jan 10, 2018
@alexeagle
build: move repeated tsconfig attributes to a macro (#20964)
5ede67c 
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor

PR Close #20964
@alexeagle alexeagle closed this in c4f02e2 Jan 10, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@alexeagle @leo6104
build: move repeated tsconfig attributes to a macro (angular#20964)
4d2091a 
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor

PR Close angular#20964
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@alexeagle
build: move repeated tsconfig attributes to a macro (angular#20964)
a9dcaba 
This helps ensure we use the same tsconfig.json file for all compilations.
Next steps are to make it the same tsconfig.json file used by the editor

PR Close angular#20964
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexeagle @mary-poppins @IgorMinar @jasonaden @googlebot