Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify heroes example #21216

Closed
wants to merge 1 commit into from

Conversation

reneras
Copy link
Contributor

@reneras reneras commented Dec 29, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #20904

What is the new behavior?

Instructions under Heroes HTTP subsection describes where to define the httpOptions constant.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@jenniferfell jenniferfell added feature Issue that requests a new feature state: has PR subtype: docs-clarification aio: preview target: patch This PR is targeted for the next patch release and removed comp: docs/tutorial-quickstart state: has PR feature Issue that requests a new feature labels Jun 6, 2018
@mary-poppins
Copy link

You can preview 8dc8db9 at https://pr21216-8dc8db9.ngbuilds.io/.

@sreevani-ship-it
Copy link
Contributor

LGTM.

@jenniferfell jenniferfell added state: community Someone from the Angular community is working on this issue or submitted this PR and removed state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 23, 2018
@brandonroberts brandonroberts self-assigned this Aug 2, 2018
@brandonroberts brandonroberts changed the title docs(aio): clarify heroes example docs: clarify heroes example Aug 2, 2018
@mary-poppins
Copy link

You can preview 302daa1 at https://pr21216-302daa1.ngbuilds.io/.

@brandonroberts brandonroberts added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2018
kara pushed a commit that referenced this pull request Aug 6, 2018
@kara kara closed this in 6861bc5 Aug 6, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants