Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(aio): upgrade to cli 1.6.3 #21350

Closed
wants to merge 2 commits into from
Closed

build(aio): upgrade to cli 1.6.3 #21350

wants to merge 2 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar mentioned this pull request Jan 6, 2018
Closed
@IgorMinar IgorMinar force-pushed the aio/upgrade-to-cli-1.6.3 branch 2 times, most recently from 0a29e87 to ec82767 Compare January 6, 2018 03:33
@IgorMinar IgorMinar changed the title upgrade aio to cli 1.6.3 build(aio): upgrade to cli 1.6.3 Jan 6, 2018
@mary-poppins
Copy link

You can preview d43e8b6 at https://pr21350-d43e8b6.ngbuilds.io/.

@IgorMinar IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release comp: aio labels Jan 6, 2018
@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Jan 7, 2018
FrozenPandaz
FrozenPandaz reviewed Jan 8, 2018
View reviewed changes
aio/yarn.lock Outdated
resolved "https://registry.yarnpkg.com/typescript/-/typescript-2.6.2.tgz#3c5b6fd7f6de0914269027f03c0946758f7673a4"

uglify-es@^3.3.4:
version "3.3.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this did not move to 3.3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.3.5 was released after this PR was created. I updated the lock file to update to 3.3.5 now.

@IgorMinar IgorMinar force-pushed the aio/upgrade-to-cli-1.6.3 branch 2 times, most recently from ec38dba to d2becd1 Compare January 8, 2018 09:05
@mary-poppins
Copy link

You can preview ec38dba at https://pr21350-ec38dba.ngbuilds.io/.

@mary-poppins
Copy link

You can preview d2becd1 at https://pr21350-d2becd1.ngbuilds.io/.

@gkalpak gkalpak mentioned this pull request Jan 8, 2018
Closed
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2018
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Jan 8, 2018
@petebacondarwin
Copy link
Member

The failure in Travis was because the builds were actually "smaller" than the expected size (by more than the prescribed 1%).

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 8, 2018
@gkalpak
Copy link
Member

gkalpak commented Jan 8, 2018

The sizes still need to be updated (decreased) afaict.

@mary-poppins
Copy link

You can preview f0762aa at https://pr21350-f0762aa.ngbuilds.io/.

@IgorMinar IgorMinar mentioned this pull request Jan 9, 2018
Closed
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
243101e 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js
@IgorMinar
build(aio): upgrade to uglify-es@3.3.5
f91dc81 
This should fix the size regression spotted via the previous commit.

-rw-r--r--  1 iminar  eng   72498 Jan  8 00:03 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14872 Jan  8 00:03 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  8 00:03 dist/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  453905 Jan  8 00:03 dist/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40264 Jan  8 00:03 dist/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  8 00:03 dist/worker-basic.min.js
@mary-poppins
Copy link

You can preview f91dc81 at https://pr21350-f91dc81.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 10, 2018
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@IgorMinar @alexeagle
build(aio): upgrade to @angular/cli@1.6.3 (#21350)
c46afce 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js

PR Close #21350
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@IgorMinar @alexeagle
build(aio): upgrade to uglify-es@3.3.5 (#21350)
0a5a878 
This should fix the size regression spotted via the previous commit.

-rw-r--r--  1 iminar  eng   72498 Jan  8 00:03 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14872 Jan  8 00:03 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  8 00:03 dist/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  453905 Jan  8 00:03 dist/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40264 Jan  8 00:03 dist/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  8 00:03 dist/worker-basic.min.js

PR Close #21350
@alexeagle alexeagle closed this in c6b2f07 Jan 10, 2018
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@IgorMinar @alexeagle
build(aio): upgrade to uglify-es@3.3.5 (#21350)
ff6047c 
This should fix the size regression spotted via the previous commit.

-rw-r--r--  1 iminar  eng   72498 Jan  8 00:03 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14872 Jan  8 00:03 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  8 00:03 dist/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  453905 Jan  8 00:03 dist/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40264 Jan  8 00:03 dist/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  8 00:03 dist/worker-basic.min.js

PR Close #21350
@IgorMinar IgorMinar mentioned this pull request Jan 10, 2018
Closed
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Jan 11, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): upgrade to @angular/cli@1.6.3 (angular#21350)
0c1b03c 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js

PR Close angular#21350
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build(aio): upgrade to uglify-es@3.3.5 (angular#21350)
1d5d76e 
This should fix the size regression spotted via the previous commit.

-rw-r--r--  1 iminar  eng   72498 Jan  8 00:03 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14872 Jan  8 00:03 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  8 00:03 dist/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  453905 Jan  8 00:03 dist/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40264 Jan  8 00:03 dist/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  8 00:03 dist/worker-basic.min.js

PR Close angular#21350
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz left review comments

@gkalpak gkalpak gkalpak approved these changes

@petebacondarwin petebacondarwin Awaiting requested review from petebacondarwin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@IgorMinar @mary-poppins @petebacondarwin @gkalpak @FrozenPandaz @googlebot