Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9kb size regression in angular.io between cli 1.6.0-rc.0 and 1.6.3 #9108

Closed
IgorMinar opened this issue Jan 6, 2018 · 6 comments
Closed

9kb size regression in angular.io between cli 1.6.0-rc.0 and 1.6.3 #9108

IgorMinar opened this issue Jan 6, 2018 · 6 comments

Comments

@IgorMinar
Copy link
Contributor

IgorMinar commented Jan 6, 2018 •
edited

Repro: angular/angular#21350

cli version build-optimizer version main.js size in bytes
1.6.0-rc.0 0.0.31 457592
1.6.3 0.0.36 466682
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 6, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
dbd810f 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 17:57 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 17:57 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 17:57 dist/inline.3ac5a135e3db42fa8f39.bundle.js
-rw-r--r--  1 iminar  eng  466682 Jan  5 17:57 dist/main.eb28e3f2153edf59c5e3.bundle.js
-rw-r--r--  1 iminar  eng   40557 Jan  5 17:57 dist/polyfills.f5bd34ec342f63dd1040.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 17:57 dist/worker-basic.min.js
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 6, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
0a29e87 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 17:57 dist/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 17:57 dist/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 17:57 dist/inline.3ac5a135e3db42fa8f39.bundle.js
-rw-r--r--  1 iminar  eng  466682 Jan  5 17:57 dist/main.eb28e3f2153edf59c5e3.bundle.js
-rw-r--r--  1 iminar  eng   40557 Jan  5 17:57 dist/polyfills.f5bd34ec342f63dd1040.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 17:57 dist/worker-basic.min.js
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 6, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
ec82767 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 6, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
d43e8b6 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js
@FrozenPandaz
Copy link
Contributor

FrozenPandaz commented Jan 6, 2018 •
edited

@clydin was able to narrow it down to an update to uglify-es (dependency of uglifyjs-webpack-plugin)

v3.2.2 results in a main.js of 455kb
v3.3.0 (immediate next version) results in a main.js of 466kb

corresponding commit range mishoo/UglifyJS@f8ff349...01bb08b

@clydin
Copy link
Member

clydin commented Jan 8, 2018

This appears to be corrected with uglify-es v3.3.5. With this version on CLI 1.6.3, the main bundle size is 453905 bytes. This version will be installed automatically on a new CLI 1.6.3 install.

@IgorMinar
Copy link
Contributor Author

IgorMinar commented Jan 8, 2018 via email

@FrozenPandaz FrozenPandaz mentioned this issue Jan 8, 2018
Closed
@IgorMinar
Copy link
Contributor Author

Nice! It seems that with uglify-es 3.3.5 the size of the main bundle has decreased by 11.6kb. that's great! I'll update my PR angular/angular#21350 and rerun it on CI to confirm that this is really true.

Thanks @clydin for investigating this.

@IgorMinar
Copy link
Contributor Author

yup. it worked. and in fact it improved the main bundle size by almost 3kb. thanks!

IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 9, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
7751392 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js
IgorMinar added a commit to IgorMinar/angular that referenced this issue Jan 10, 2018
@IgorMinar
build(aio): upgrade to @angular/cli@1.6.3
243101e 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js
alexeagle pushed a commit to angular/angular that referenced this issue Jan 10, 2018
@IgorMinar @alexeagle
build(aio): upgrade to @angular/cli@1.6.3 (#21350)
c46afce 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js

PR Close #21350
alexeagle pushed a commit to angular/angular that referenced this issue Jan 10, 2018
@IgorMinar @alexeagle
build(aio): upgrade to @angular/cli@1.6.3 (#21350)
c6b2f07 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js

PR Close #21350
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
@IgorMinar @leo6104
build(aio): upgrade to @angular/cli@1.6.3 (angular#21350)
0c1b03c 
This change introduces a size regression of 9kb for main.js :-(

I filed an issue for this: angular/angular-cli#9108

-rw-r--r--  1 iminar  eng   72546 Jan  5 19:27 dist.cli-1.6.3/0.86a7a08f7866e6cdc36f.chunk.js
-rw-r--r--  1 iminar  eng   14893 Jan  5 19:27 dist.cli-1.6.3/4.c719ac5645940382cdce.chunk.js
-rw-r--r--  1 iminar  eng    1558 Jan  5 19:27 dist.cli-1.6.3/inline.7722895d8c844f710bcd.bundle.js
-rw-r--r--  1 iminar  eng  466484 Jan  5 19:27 dist.cli-1.6.3/main.faff0e2da95443f759f5.bundle.js
-rw-r--r--  1 iminar  eng   40363 Jan  5 19:27 dist.cli-1.6.3/polyfills.87edf5d695f14a29bf91.bundle.js
-rw-r--r--  1 iminar  eng   54001 Jan  5 19:27 dist.cli-1.6.3/worker-basic.min.js

PR Close angular#21350
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IgorMinar @FrozenPandaz @clydin