New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): add short description for entryComponents #21360
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Relates to #21257 |
aio/content/guide/cheatsheet.md
Outdated
@@ -44,6 +44,9 @@ is available to <code>declarations</code> of this module.</p> | |||
<td><p>List of dependency injection providers visible both to the contents of this module and to importers of this module.</p> | |||
</td> | |||
</tr><tr> | |||
<td><code><b>entryComponents:</b> [SomeComponent, OtherComponent]</code></td> | |||
<td><p>List of components that will be compiled when the module is defined.</p></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this description is accurate. They are components that could be created and attached to nodes without being part of another components template (i.e. dynamically), but that doesn't mean they will be compiled/created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is great! (PS: you might like to rebase as important changes have been merged. And squash.)
@VadimDez ... and also not referenced in any defined routes in that module. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information