Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable integration/cli-hello-world test #21492

Closed
wants to merge 1 commit into from
Closed

ci: disable integration/cli-hello-world test #21492

wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

No description provided.

@alexeagle
ci: disable integration/cli-hello-world test
e94fb16 
it is non-hermetic and breaks often due to unpinned dependencies.
gkalpak
gkalpak reviewed Jan 11, 2018
View reviewed changes
integration/run_tests.sh
)
./ng-cli-create.sh cli-hello-world
# cli-hello-world test is disabled because it uses un-pinned dependencies
# TODO(alexeagle): re-enable when it's pinned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm...I thought the whole idea of this example was to test with the latest dependencies (in the specified ranges) 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need such an assertion, but we want to find another place for it - either a separate CircleCI status, or even a separate repo, using http://renovateapp.com to send PRs that bump the lock file, so that it only goes red on a PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 to that.
(I was just confused by the comment to pin dependencies and re-enable.)

@alexeagle alexeagle added the area: build & ci Related the build and CI infrastructure of the project label Jan 12, 2018
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 12, 2018
alexeagle added a commit that referenced this pull request Jan 12, 2018
@alexeagle
ci: disable integration/cli-hello-world test (#21492)
a4cbe35 
it is non-hermetic and breaks often due to unpinned dependencies.

PR Close #21492
@alexeagle alexeagle closed this in 7c414fc Jan 12, 2018
@alexeagle alexeagle deleted the fix_travis branch January 12, 2018 22:59
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@alexeagle @leo6104
ci: disable integration/cli-hello-world test (angular#21492)
5ab26d6 
it is non-hermetic and breaks often due to unpinned dependencies.

PR Close angular#21492
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexeagle @jasonaden @gkalpak @googlebot