Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable integration/cli-hello-world test #21492

Closed
wants to merge 1 commit into from
Closed

ci: disable integration/cli-hello-world test #21492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 15 additions & 12 deletions integration/run_tests.sh
View file
Open in desktop
Expand Up @@ -19,18 +19,21 @@ rm_cache
mkdir $cache
trap rm_cache EXIT

# We need to install `ng` but don't want to do it globally so we place it into `.ng-cli` folder.
(
mkdir -p .ng-cli
cd .ng-cli

# workaround for https://github.com/yarnpkg/yarn/pull/4464 which causes cli to be installed into the root node_modules
echo '{"name": "ng-cli"}' > package.json
yarn init -y

yarn add @angular/cli@$ANGULAR_CLI_VERSION --cache-folder ../$cache
)
./ng-cli-create.sh cli-hello-world
# cli-hello-world test is disabled because it uses un-pinned dependencies
# TODO(alexeagle): re-enable when it's pinned
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm...I thought the whole idea of this example was to test with the latest dependencies (in the specified ranges) 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need such an assertion, but we want to find another place for it - either a separate CircleCI status, or even a separate repo, using http://renovateapp.com to send PRs that bump the lock file, so that it only goes red on a PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 to that.
(I was just confused by the comment to pin dependencies and re-enable.)


# # We need to install `ng` but don't want to do it globally so we place it into `.ng-cli` folder.
# (
# mkdir -p .ng-cli
# cd .ng-cli

# # workaround for https://github.com/yarnpkg/yarn/pull/4464 which causes cli to be installed into the root node_modules
# echo '{"name": "ng-cli"}' > package.json
# yarn init -y

# yarn add @angular/cli@$ANGULAR_CLI_VERSION --cache-folder ../$cache
# )
# ./ng-cli-create.sh cli-hello-world

for testDir in $(ls | grep -v node_modules) ; do
[[ -d "$testDir" ]] || continue
Expand Down